Bug 195626 – [iOS] No DOM keypress event emitted for cursor key commands when non-editable element is focused

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Daniel Bates]

Steps To Reproduce:

The following assumes you are using an iOS device with a hardware keyboard.

1. Visit <https://unixpapa.com/js/testkey.html>.
2. Ensure modifiers and DOM 3 attributes are shown.
3. Press Control + a.

No keypress event is emitted for 'a'. But a keypress event should be emitted as we do on Mac.

[Daniel Bates]

<rdar://problem/48810626>

[Daniel Bates]

Created attachment 364404 [details]
Patch and tests

[Daniel Bates]

Bots will likely be red. Will fix up patch based on the bots.

[Wenson Hsieh]

Comment on attachment 364404 [details]
Patch and tests

View in context: https://bugs.webkit.org/attachment.cgi?id=364404&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2725
> +    // UIKit IPI do not forward to the WebView.

As we chatted about earlier, this could read a bit nicer (e.g. "These are UIKit IPI methods, so we don't forward them to the web view.")

[Daniel Bates]

(In reply to Daniel Bates from comment #3)
> Bots will likely be red. Will fix up patch based on the bots.

Nope, they won't because we skip fast/events/ios on OpenSource per <https://trac.webkit.org/browser/trunk/LayoutTests/TestExpectations?rev=242724#L37> :D and no longer mark this directory as Pass in any iOS TestExpectation file o_O. That works out well for me and the tests in this patch since they depend on UIKit fixes. However, that appears to be a regressions from <https://trac.webkit.org/changeset/190368/webkit#file7>.

[Daniel Bates]

(In reply to Daniel Bates from comment #5)
> (In reply to Daniel Bates from comment #3)
> > Bots will likely be red. Will fix up patch based on the bots.
> 
> Nope, they won't because we skip fast/events/ios on OpenSource per
> <https://trac.webkit.org/browser/trunk/LayoutTests/
> TestExpectations?rev=242724#L37> :D and no longer mark this directory as
> Pass in any iOS TestExpectation file o_O. That works out well for me and the
> tests in this patch since they depend on UIKit fixes. However, that appears
> to be a regressions from
> <https://trac.webkit.org/changeset/190368/webkit#file7>.

The tests were timing out on so we removed the PASS entry for fast/events/ios from the iOS TestExpectation file in <https://trac.webkit.org/changeset/194059/webkit> (bug #152134). So, now we do not run these tests at all, at least on the OpenSource bots.

[Daniel Bates]

Created attachment 365031 [details]
To land

[Daniel Bates]

Committed r243082: <https://trac.webkit.org/changeset/243082>