Bug 195625 - Device Orientation access permission should be denied unless explicitly granted by the client
Summary: Device Orientation access permission should be denied unless explicitly grant...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-12 09:41 PDT by Chris Dumez
Modified: 2019-03-12 13:33 PDT (History)
8 users (show)

See Also:


Attachments
Patch (17.72 KB, patch)
2019-03-12 09:42 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-03-12 09:41:07 PDT
Device Orientation access permission should be denied unless explicitly granted by the client. Currently, it is granted by default.
Comment 1 Chris Dumez 2019-03-12 09:42:58 PDT
Created attachment 364394 [details]
Patch
Comment 2 Build Bot 2019-03-12 09:45:56 PDT
Attachment 364394 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:94:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:97:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2019-03-12 13:32:44 PDT
Comment on attachment 364394 [details]
Patch

Clearing flags on attachment: 364394

Committed r242823: <https://trac.webkit.org/changeset/242823>
Comment 4 Chris Dumez 2019-03-12 13:32:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-12 13:33:25 PDT
<rdar://problem/48820909>