Bug 195609 – In CachedFrame's constructor, release-assert that DOMWindow still has a frame after page-caching subframes

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

https://trac.webkit.org/changeset/242677 added release assertions to DOMWindow::suspendForPageCache.
But we still won't be able to tell whether active DOM objects are detaching frames,
or if creating CachedFrame on subframes is causing the frame to go way.

Add a release assertion immediately after creating CachedFrame for subframes to distinguish this case.

[Ryosuke Niwa]

Created attachment 364362 [details]
Adds a release assert

[EWS Watchlist]

Comment on attachment 364362 [details]
Adds a release assert

Attachment 364362 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11470551

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall.https.html

[EWS Watchlist]

Created attachment 364372 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Chris Dumez]

Comment on attachment 364372 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

Unrelated.

[WebKit Commit Bot]

Comment on attachment 364362 [details]
Adds a release assert

Clearing flags on attachment: 364362

Committed r242797: <https://trac.webkit.org/changeset/242797>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48811192>

[Chris Dumez]

Comment on attachment 364362 [details]
Adds a release assert

View in context: https://bugs.webkit.org/attachment.cgi?id=364362&action=review

> Source/WebCore/history/CachedFrame.cpp:150
> +    RELEASE_ASSERT(m_document->domWindow()->frame());

Getting hit (rdar://problem/49877867).