Bug 195600 - Remove OpenCube QuickMenu quirks from navigator.appVersion
Summary: Remove OpenCube QuickMenu quirks from navigator.appVersion
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Keywords: InRadar
Depends on:
Reported: 2019-03-11 20:53 PDT by Ryosuke Niwa
Modified: 2019-03-11 23:08 PDT (History)
7 users (show)

See Also:

Cleanup (2.57 KB, patch)
2019-03-11 21:18 PDT, Ryosuke Niwa
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-03-11 20:53:22 PDT
https://trac.webkit.org/changeset/35050 added a site specific quirk for OpenCube QuickMenu,
which was used by NWA.com at the time, and erroneously detected any browser which returns
"4." in navigator.appVersion to be Netscape Navigator 4.x.

It has been 11 years since then, and NWA.com simply redirects to delta.com now.
Comment 1 Ryosuke Niwa 2019-03-11 20:55:55 PDT
Blink "removed" this site specific quirks in https://chromium.googlesource.com/chromium/src/+/dfa9e59a223802c69955a01d4c5f8fd8277c7fb2

The patch added a new implementation of navigator.appVersion to NavigatorID and made Navigator supplemented by NavigatorID but without ever removing Navigator::appVersion, which had the site specific quirk. Arguably, this was unintentional behavioral change by Chris.

The unused code in Navigator.cpp was subsequently removed in https://chromium.googlesource.com/chromium/src/+/70bb2b39ddf4d88ba048df2a67dd7de0780d7c28
Comment 2 Ryosuke Niwa 2019-03-11 21:05:22 PDT
The fact Blink/Chrome has been shopping a major browser engine for six years since the relevant code was removed is a good enough evidence that this workaround is no longer needed for Web compatibility.
Comment 3 Ryosuke Niwa 2019-03-11 21:18:51 PDT
Created attachment 364348 [details]
Comment 4 Ryosuke Niwa 2019-03-11 23:07:16 PDT
Committed r242779: <https://trac.webkit.org/changeset/242779>
Comment 5 Radar WebKit Bug Importer 2019-03-11 23:08:24 PDT