Bug 195593 - [JSC] Move species watchpoint installation from ArrayPrototype to JSGlobalObject
Summary: [JSC] Move species watchpoint installation from ArrayPrototype to JSGlobalObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-11 18:01 PDT by Yusuke Suzuki
Modified: 2019-03-13 13:28 PDT (History)
7 users (show)

See Also:


Attachments
Patch (17.04 KB, patch)
2019-03-11 18:15 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-highsierra (601.50 KB, application/zip)
2019-03-11 19:34 PDT, Build Bot
no flags Details
Patch (17.19 KB, patch)
2019-03-11 19:50 PDT, Yusuke Suzuki
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-03-11 18:01:35 PDT
[JSC] Move species watchpoint installation from ArrayPrototype to JSGlobalObject
Comment 1 Yusuke Suzuki 2019-03-11 18:15:03 PDT
Created attachment 364328 [details]
Patch
Comment 2 Build Bot 2019-03-11 19:34:46 PDT
Comment on attachment 364328 [details]
Patch

Attachment 364328 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11465019

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2019-03-11 19:34:47 PDT
Created attachment 364335 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 4 Yusuke Suzuki 2019-03-11 19:38:57 PDT
Comment on attachment 364328 [details]
Patch

Fixing crashes.
Comment 5 Yusuke Suzuki 2019-03-11 19:50:46 PDT
Created attachment 364337 [details]
Patch
Comment 6 Keith Miller 2019-03-13 13:18:10 PDT
Comment on attachment 364337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364337&action=review

r=me.

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:200
> +        if (ArrayPrototypeInternal::verbose)
> +            dataLog("Initializing Array species watchpoints for Array.prototype: ", pointerDump(arrayPrototype), " with structure: ", pointerDump(arrayPrototype->structure(vm)), "\nand Array: ", pointerDump(globalObject->arrayConstructor()), " with structure: ", pointerDump(globalObject->arrayConstructor()->structure(vm)), "\n");

Nit: I prefer dataLogLnIf(ArrayPrototypeInternal::verbose, ...)
Comment 7 Yusuke Suzuki 2019-03-13 13:18:48 PDT
Comment on attachment 364337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364337&action=review

>> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:200
>> +            dataLog("Initializing Array species watchpoints for Array.prototype: ", pointerDump(arrayPrototype), " with structure: ", pointerDump(arrayPrototype->structure(vm)), "\nand Array: ", pointerDump(globalObject->arrayConstructor()), " with structure: ", pointerDump(globalObject->arrayConstructor()->structure(vm)), "\n");
> 
> Nit: I prefer dataLogLnIf(ArrayPrototypeInternal::verbose, ...)

Sounds better! Fixed.
Comment 8 Yusuke Suzuki 2019-03-13 13:28:02 PDT
Committed r242902: <https://trac.webkit.org/changeset/242902>
Comment 9 Radar WebKit Bug Importer 2019-03-13 13:28:28 PDT
<rdar://problem/48860522>