Bug 195593 – [JSC] Move species watchpoint installation from ArrayPrototype to JSGlobalObject

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Move species watchpoint installation from ArrayPrototype to JSGlobalObject

[Yusuke Suzuki]

Created attachment 364328 [details]
Patch

[EWS Watchlist]

Comment on attachment 364328 [details]
Patch

Attachment 364328 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11465019

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 364335 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Yusuke Suzuki]

Comment on attachment 364328 [details]
Patch

Fixing crashes.

[Yusuke Suzuki]

Created attachment 364337 [details]
Patch

[Keith Miller]

Comment on attachment 364337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364337&action=review

r=me.

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:200
> +        if (ArrayPrototypeInternal::verbose)
> +            dataLog("Initializing Array species watchpoints for Array.prototype: ", pointerDump(arrayPrototype), " with structure: ", pointerDump(arrayPrototype->structure(vm)), "\nand Array: ", pointerDump(globalObject->arrayConstructor()), " with structure: ", pointerDump(globalObject->arrayConstructor()->structure(vm)), "\n");

Nit: I prefer dataLogLnIf(ArrayPrototypeInternal::verbose, ...)

[Yusuke Suzuki]

Comment on attachment 364337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364337&action=review

>> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:200
>> +            dataLog("Initializing Array species watchpoints for Array.prototype: ", pointerDump(arrayPrototype), " with structure: ", pointerDump(arrayPrototype->structure(vm)), "\nand Array: ", pointerDump(globalObject->arrayConstructor()), " with structure: ", pointerDump(globalObject->arrayConstructor()->structure(vm)), "\n");
> 
> Nit: I prefer dataLogLnIf(ArrayPrototypeInternal::verbose, ...)

Sounds better! Fixed.

[Yusuke Suzuki]

Committed r242902: <https://trac.webkit.org/changeset/242902>

[Radar WebKit Bug Importer]

<rdar://problem/48860522>