Bug 195587 - Web Inspector: Database: lazily create the agent
Summary: Web Inspector: Database: lazily create the agent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 195971
  Show dependency treegraph
 
Reported: 2019-03-11 17:50 PDT by Devin Rousso
Modified: 2019-03-20 11:53 PDT (History)
8 users (show)

See Also:


Attachments
Patch (33.55 KB, patch)
2019-03-17 14:34 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-highsierra (2.46 MB, application/zip)
2019-03-17 15:38 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.67 MB, application/zip)
2019-03-17 15:50 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews112 for mac-highsierra (2.30 MB, application/zip)
2019-03-17 16:21 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.56 MB, application/zip)
2019-03-17 16:36 PDT, EWS Watchlist
no flags Details
Patch (39.24 KB, patch)
2019-03-17 16:59 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (37.95 KB, patch)
2019-03-19 15:53 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (38.11 KB, patch)
2019-03-19 17:30 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (38.18 KB, patch)
2019-03-19 17:41 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (3.22 MB, application/zip)
2019-03-19 22:44 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-03-11 17:50:30 PDT
.
Comment 1 Radar WebKit Bug Importer 2019-03-11 17:54:11 PDT
<rdar://problem/48791735>
Comment 2 Devin Rousso 2019-03-17 14:34:49 PDT
Created attachment 364975 [details]
Patch

Looks like we never had inspector tests for `DatabaseAgent` or `WI.databaseManager` :(\nI'll need to add some.
Comment 3 EWS Watchlist 2019-03-17 15:38:30 PDT Comment hidden (obsolete)
Comment 4 EWS Watchlist 2019-03-17 15:38:32 PDT Comment hidden (obsolete)
Comment 5 EWS Watchlist 2019-03-17 15:50:20 PDT Comment hidden (obsolete)
Comment 6 EWS Watchlist 2019-03-17 15:50:22 PDT Comment hidden (obsolete)
Comment 7 EWS Watchlist 2019-03-17 16:21:57 PDT Comment hidden (obsolete)
Comment 8 EWS Watchlist 2019-03-17 16:21:59 PDT Comment hidden (obsolete)
Comment 9 EWS Watchlist 2019-03-17 16:36:42 PDT Comment hidden (obsolete)
Comment 10 EWS Watchlist 2019-03-17 16:36:44 PDT Comment hidden (obsolete)
Comment 11 Devin Rousso 2019-03-17 16:59:53 PDT
Created attachment 364986 [details]
Patch
Comment 12 Devin Rousso 2019-03-19 15:53:19 PDT
Created attachment 365250 [details]
Patch
Comment 13 Devin Rousso 2019-03-19 17:30:03 PDT
Created attachment 365270 [details]
Patch
Comment 14 Devin Rousso 2019-03-19 17:41:21 PDT
Created attachment 365272 [details]
Patch
Comment 15 EWS Watchlist 2019-03-19 22:44:03 PDT Comment hidden (obsolete)
Comment 16 EWS Watchlist 2019-03-19 22:44:05 PDT Comment hidden (obsolete)
Comment 17 WebKit Commit Bot 2019-03-20 11:53:54 PDT
Comment on attachment 365272 [details]
Patch

Clearing flags on attachment: 365272

Committed r243219: <https://trac.webkit.org/changeset/243219>
Comment 18 WebKit Commit Bot 2019-03-20 11:53:55 PDT
All reviewed patches have been landed.  Closing bug.