Bug 195585 - API test WebKit.RequestTextInputContext fails on iOS
Summary: API test WebKit.RequestTextInputContext fails on iOS
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on:
Reported: 2019-03-11 17:46 PDT by Tim Horton
Modified: 2019-03-11 18:55 PDT (History)
5 users (show)

See Also:

Patch (9.01 KB, patch)
2019-03-11 17:46 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (9.10 KB, patch)
2019-03-11 18:02 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-03-11 17:46:06 PDT
API test WebKit.RequestTextInputContext fails on iOS
Comment 1 Tim Horton 2019-03-11 17:46:25 PDT
Created attachment 364320 [details]
Comment 2 Simon Fraser (smfr) 2019-03-11 17:55:36 PDT
Comment on attachment 364320 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=364320&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:4834
> +    // FIXME: It should be easier to talk about WKWebView coordinates in a consistent and cross-platform way.
> +    // Currently, neither "root view" nor "window" mean "WKWebView coordinates" on both platforms.

You should probably reference webkit.org/b/193649
Comment 3 Tim Horton 2019-03-11 18:02:33 PDT
Created attachment 364325 [details]
Comment 4 WebKit Commit Bot 2019-03-11 18:53:16 PDT
The commit-queue encountered the following flaky tests while processing attachment 364325 [details]:

legacy-animation-engine/compositing/updates/animation-non-composited.html bug 195596 (author: graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2019-03-11 18:54:04 PDT
Comment on attachment 364325 [details]

Clearing flags on attachment: 364325

Committed r242762: <https://trac.webkit.org/changeset/242762>
Comment 6 WebKit Commit Bot 2019-03-11 18:54:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-03-11 18:55:20 PDT