Bug 195583 - [Mac] Ensure Apple Pay is unavailable when PassKit.framework is missing
Summary: [Mac] Ensure Apple Pay is unavailable when PassKit.framework is missing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-11 17:06 PDT by Andy Estes
Modified: 2019-03-12 08:07 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.81 KB, patch)
2019-03-11 17:10 PDT, Andy Estes
dbates: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.85 MB, application/zip)
2019-03-11 22:58 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-03-11 17:06:03 PDT
[Mac] Ensure Apple Pay is unavailable when PassKit.framework is missing
Comment 1 Andy Estes 2019-03-11 17:06:16 PDT
rdar://problem/48420224
Comment 2 Andy Estes 2019-03-11 17:10:47 PDT
Created attachment 364316 [details]
Patch
Comment 3 Daniel Bates 2019-03-11 19:25:40 PDT
Comment on attachment 364316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364316&action=review

> Source/WebKit/ChangeLog:10
> +        Partition. We need to check if the framework is available before calling into it.

We shipped like this :(
Comment 4 Build Bot 2019-03-11 22:58:44 PDT
Comment on attachment 364316 [details]
Patch

Attachment 364316 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11467672

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall.https.html
Comment 5 Build Bot 2019-03-11 22:58:47 PDT
Created attachment 364354 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 6 Andy Estes 2019-03-12 08:07:23 PDT
Committed r242795: <https://trac.webkit.org/changeset/242795>