Bug 19557 - (JavaScriptCore) minidom uses C++ style comments
Summary: (JavaScriptCore) minidom uses C++ style comments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-15 08:49 PDT by Christian Dywan
Modified: 2008-06-16 06:42 PDT (History)
0 users

See Also:


Attachments
Use only C style comments in minidom (10.12 KB, patch)
2008-06-15 08:53 PDT, Christian Dywan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Dywan 2008-06-15 08:49:41 PDT
The JavaScriptCore test program minidom is written in C. However it makes use of C++ style "//" comments, including wtf headers used in minidom. That means only compilers supporting that part of C99 or particularly support for C++ style comments can build minidom.
Comment 1 Christian Dywan 2008-06-15 08:53:46 PDT
Created attachment 21713 [details]
Use only C style comments in minidom

This patch fixes the comments in minidom and C headers from wtf used by minidom. It was tested with gcc in c89 mode.
Comment 2 Sam Weinig 2008-06-15 10:26:37 PDT
Comment on attachment 21713 [details]
Use only C style comments in minidom

This needs a ChangeLog.
Comment 3 Christian Dywan 2008-06-16 06:42:10 PDT
Comment on attachment 21713 [details]
Use only C style comments in minidom

Committed in revision 34598.