This is much cleaner and simpler.
<rdar://problem/48778727>
Created attachment 364301 [details] Patch
Comment on attachment 364301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364301&action=review > Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.css:-38 > -body[dir=ltr] .details-section .row.box-model .label { Removing this entirely was intentional. I think it looks better when the text isn't as indented.
Comment on attachment 364301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364301&action=review r=me, great cleanup! > Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css:81 > +#edit-breakpoint-popover-auto-continue { Style: these should be on a single line. > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:48 > +.content-view.dom-tree.show-gutter .tree-outline.dom { This rule belongs in DOMTreeContentView.css. > Source/WebInspectorUI/UserInterface/Views/FindBanner.css:69 > +.find-banner > :first-child { So much better! > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css:143 > + /* Positions so the text in the menu aligns with the text in .title for text only path components. */ "text-only" should be hyphenated, since it's a compound adjective preceding the noun it modifies.
Comment on attachment 364301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364301&action=review >> Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css:81 >> +#edit-breakpoint-popover-auto-continue { > > Style: these should be on a single line. These are two different selectors. We normally put a separate selector on each line. The only time we don't is if we use a `:matches`. >> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:48 >> +.content-view.dom-tree.show-gutter .tree-outline.dom { > > This rule belongs in DOMTreeContentView.css. Will move.
Created attachment 364319 [details] Patch
Comment on attachment 364319 [details] Patch Clearing flags on attachment: 364319 Committed r242768: <https://trac.webkit.org/changeset/242768>
All reviewed patches have been landed. Closing bug.