Bug 195569 – Web Inspector: use -webkit-{margin,padding}-{start,end} instead of [dir={ltr/rtl}] rules

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

This is much cleaner and simpler.

[Radar WebKit Bug Importer]

<rdar://problem/48778727>

[Devin Rousso]

Created attachment 364301 [details]
Patch

[Devin Rousso]

Comment on attachment 364301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364301&action=review

> Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.css:-38
> -body[dir=ltr] .details-section .row.box-model .label {

Removing this entirely was intentional.  I think it looks better when the text isn't as indented.

[Matt Baker]

Comment on attachment 364301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364301&action=review

r=me, great cleanup!

> Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css:81
> +#edit-breakpoint-popover-auto-continue {

Style: these should be on a single line.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:48
> +.content-view.dom-tree.show-gutter .tree-outline.dom {

This rule belongs in DOMTreeContentView.css.

> Source/WebInspectorUI/UserInterface/Views/FindBanner.css:69
> +.find-banner > :first-child {

So much better!

> Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css:143
> +    /* Positions so the text in the menu aligns with the text in .title for text only path components. */

"text-only" should be hyphenated, since it's a compound adjective preceding the noun it modifies.

[Devin Rousso]

Comment on attachment 364301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364301&action=review

>> Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css:81
>> +#edit-breakpoint-popover-auto-continue {
> 
> Style: these should be on a single line.

These are two different selectors.  We normally put a separate selector on each line.  The only time we don't is if we use a `:matches`.

>> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:48
>> +.content-view.dom-tree.show-gutter .tree-outline.dom {
> 
> This rule belongs in DOMTreeContentView.css.

Will move.

[Devin Rousso]

Created attachment 364319 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 364319 [details]
Patch

Clearing flags on attachment: 364319

Committed r242768: <https://trac.webkit.org/changeset/242768>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.