Bug 195569 - Web Inspector: use -webkit-{margin,padding}-{start,end} instead of [dir={ltr/rtl}] rules
Summary: Web Inspector: use -webkit-{margin,padding}-{start,end} instead of [dir={ltr/...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-11 13:07 PDT by Devin Rousso
Modified: 2019-03-11 20:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (74.64 KB, patch)
2019-03-11 15:35 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (74.47 KB, patch)
2019-03-11 17:42 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-03-11 13:07:31 PDT
This is much cleaner and simpler.
Comment 1 Radar WebKit Bug Importer 2019-03-11 13:07:56 PDT
<rdar://problem/48778727>
Comment 2 Devin Rousso 2019-03-11 15:35:06 PDT
Created attachment 364301 [details]
Patch
Comment 3 Devin Rousso 2019-03-11 15:37:23 PDT
Comment on attachment 364301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364301&action=review

> Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.css:-38
> -body[dir=ltr] .details-section .row.box-model .label {

Removing this entirely was intentional.  I think it looks better when the text isn't as indented.
Comment 4 Matt Baker 2019-03-11 16:49:21 PDT
Comment on attachment 364301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364301&action=review

r=me, great cleanup!

> Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css:81
> +#edit-breakpoint-popover-auto-continue {

Style: these should be on a single line.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:48
> +.content-view.dom-tree.show-gutter .tree-outline.dom {

This rule belongs in DOMTreeContentView.css.

> Source/WebInspectorUI/UserInterface/Views/FindBanner.css:69
> +.find-banner > :first-child {

So much better!

> Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css:143
> +    /* Positions so the text in the menu aligns with the text in .title for text only path components. */

"text-only" should be hyphenated, since it's a compound adjective preceding the noun it modifies.
Comment 5 Devin Rousso 2019-03-11 17:11:05 PDT
Comment on attachment 364301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364301&action=review

>> Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css:81
>> +#edit-breakpoint-popover-auto-continue {
> 
> Style: these should be on a single line.

These are two different selectors.  We normally put a separate selector on each line.  The only time we don't is if we use a `:matches`.

>> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:48
>> +.content-view.dom-tree.show-gutter .tree-outline.dom {
> 
> This rule belongs in DOMTreeContentView.css.

Will move.
Comment 6 Devin Rousso 2019-03-11 17:42:23 PDT
Created attachment 364319 [details]
Patch
Comment 7 WebKit Commit Bot 2019-03-11 20:22:35 PDT
Comment on attachment 364319 [details]
Patch

Clearing flags on attachment: 364319

Committed r242768: <https://trac.webkit.org/changeset/242768>
Comment 8 WebKit Commit Bot 2019-03-11 20:22:37 PDT
All reviewed patches have been landed.  Closing bug.