WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
195567
Update device orientation & motion permission native SPI as per latest proposal
https://bugs.webkit.org/show_bug.cgi?id=195567
Summary
Update device orientation & motion permission native SPI as per latest proposal
Chris Dumez
Reported
2019-03-11 12:54:18 PDT
Update device orientation & motion permission native SPI as per latest proposal.
Attachments
Patch
(19.24 KB, patch)
2019-03-11 13:08 PDT
,
Chris Dumez
youennf
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2019-03-11 13:08:48 PDT
Created
attachment 364281
[details]
Patch
EWS Watchlist
Comment 2
2019-03-11 13:11:00 PDT
Attachment 364281
[details]
did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 3
2019-03-11 16:12:27 PDT
Comment on
attachment 364281
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=364281&action=review
> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:181 > +- (void)_webView:(WKWebView *)webView shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:(WKFrameInfo *)securityOrigin decisionHandler:(void (^)(BOOL))decisionHandler WK_API_AVAILABLE(ios(WK_IOS_TBA));
s/securityOrigin/requestingFrame/
Chris Dumez
Comment 4
2019-03-11 16:14:25 PDT
Committed
r242753
: <
https://trac.webkit.org/changeset/242753
>
Radar WebKit Bug Importer
Comment 5
2019-03-11 16:15:27 PDT
<
rdar://problem/48788052
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug