Bug 195557 - [ews-build] unit-tests fail when passwords.json is missing
Summary: [ews-build] unit-tests fail when passwords.json is missing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-11 08:25 PDT by Aakash Jain
Modified: 2019-03-11 09:39 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch (3.06 KB, patch)
2019-03-11 08:29 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-03-11 08:25:06 PDT
unit-tests in loadConfig_unittest.py fail when passwords.json is missing. This file is not checked-in to the repository. So the unit-tests should be able to run without this file.

Exception:


[~/OpenSource/Tools/BuildSlaveSupport/ews-build]$python runUnittests.py 
......................................................E....................
======================================================================
ERROR: test_configuration (loadConfig_unittest.ConfigDotJSONTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jain/code/OpenSource/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py", line 36, in test_configuration
    loadConfig.loadBuilderConfig({}, master_prefix_path=cwd)
  File "/Users/jain/code/OpenSource/Tools/BuildSlaveSupport/ews-build/loadConfig.py", line 42, in loadBuilderConfig
    passwords = json.load(open(os.path.join(master_prefix_path, 'passwords.json')))
IOError: [Errno 2] No such file or directory: 'passwords.json'
Comment 1 Aakash Jain 2019-03-11 08:29:34 PDT
Created attachment 364253 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2019-03-11 09:38:11 PDT
Comment on attachment 364253 [details]
Proposed patch

Clearing flags on attachment: 364253

Committed r242707: <https://trac.webkit.org/changeset/242707>
Comment 3 WebKit Commit Bot 2019-03-11 09:38:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-03-11 09:39:23 PDT
<rdar://problem/48769818>