Bug 195542 - Add utility function to allow easy reverse range-based iteration of a container
Summary: Add utility function to allow easy reverse range-based iteration of a container
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-10 20:59 PDT by Sam Weinig
Modified: 2019-03-13 19:46 PDT (History)
4 users (show)

See Also:


Attachments
Patch (10.40 KB, patch)
2019-03-10 21:05 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (10.28 KB, patch)
2019-03-13 18:45 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (10.29 KB, patch)
2019-03-13 19:07 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2019-03-10 20:59:13 PDT
Add utility function to allow easy reverse range-based iteration of a container
Comment 1 Sam Weinig 2019-03-10 21:05:38 PDT
Created attachment 364227 [details]
Patch
Comment 2 WebKit Commit Bot 2019-03-11 08:25:14 PDT
Comment on attachment 364227 [details]
Patch

Clearing flags on attachment: 364227

Committed r242702: <https://trac.webkit.org/changeset/242702>
Comment 3 WebKit Commit Bot 2019-03-11 08:25:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-03-11 08:26:23 PDT
<rdar://problem/48767598>
Comment 5 Truitt Savell 2019-03-11 08:47:30 PDT
Looks like https://trac.webkit.org/changeset/242702/webkit

just broke High Sierra:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20%28Build%29/builds/12817

/Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WTF/IteratorRange.cpp:46:42: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
/Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WTF/IteratorRange.cpp:65:42: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]

Can this be resolved quickly? Otherwise this will be rolled out.
Comment 6 Truitt Savell 2019-03-11 09:25:46 PDT
Reverted r242702 for reason:

Broke High Sierra builders.

Committed r242706: <https://trac.webkit.org/changeset/242706>
Comment 7 Sam Weinig 2019-03-13 18:45:31 PDT
Created attachment 364605 [details]
Patch
Comment 8 Sam Weinig 2019-03-13 19:07:41 PDT
Created attachment 364607 [details]
Patch
Comment 9 WebKit Commit Bot 2019-03-13 19:46:22 PDT
Comment on attachment 364607 [details]
Patch

Clearing flags on attachment: 364607

Committed r242932: <https://trac.webkit.org/changeset/242932>
Comment 10 WebKit Commit Bot 2019-03-13 19:46:23 PDT
All reviewed patches have been landed.  Closing bug.