RESOLVED FIXED 195522
Web Inspector: DOM Debugger: remove left padding when the last DOM breakpoint is removed 
https://bugs.webkit.org/show_bug.cgi?id=195522
Summary Web Inspector: DOM Debugger: remove left padding when the last DOM breakpoint...
Devin Rousso
Reported 2019-03-09 11:36:58 PST
.
Attachments
Patch (3.02 KB, patch)
2019-03-09 11:37 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-03-09 11:37:41 PST
Created attachment 364136 [details] Patch
Matt Baker
Comment 2 2019-03-12 11:50:25 PDT
Comment on attachment 364136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364136&action=review r=me > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:782 > + this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) => child.hasBreakpoint); Nice! I think keeping the early return makes it read better, and with your changes it's cleaner still: if (!breakpoints.length) { treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.None; return; } if (breakpoints.some((item) => item.disabled)) treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.DisabledBreakpoint; else treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.Breakpoint; this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) => child.hasBreakpoint);
Matt Baker
Comment 3 2019-03-12 11:50:59 PDT
Comment on attachment 364136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364136&action=review >> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:782 >> + this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) => child.hasBreakpoint); > > Nice! I think keeping the early return makes it read better, and with your changes it's cleaner still: > > if (!breakpoints.length) { > treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.None; > return; > } > > if (breakpoints.some((item) => item.disabled)) > treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.DisabledBreakpoint; > else > treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.Breakpoint; > > this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) => child.hasBreakpoint); Oh right, the early return. ;)
Matt Baker
Comment 4 2019-03-12 11:52:33 PDT
Comment on attachment 364136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364136&action=review >>> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:782 >>> + this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) => child.hasBreakpoint); >> >> Nice! I think keeping the early return makes it read better, and with your changes it's cleaner still: >> >> if (!breakpoints.length) { >> treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.None; >> return; >> } >> >> if (breakpoints.some((item) => item.disabled)) >> treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.DisabledBreakpoint; >> else >> treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.Breakpoint; >> >> this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) => child.hasBreakpoint); > > Oh right, the early return. ;) I guess `this.breakpointGutterEnabled = ...` could be moved above an early return, and it would still work, but I think it's fine as is.
WebKit Commit Bot
Comment 5 2019-03-12 12:03:07 PDT
Comment on attachment 364136 [details] Patch Clearing flags on attachment: 364136 Committed r242811: <https://trac.webkit.org/changeset/242811>
WebKit Commit Bot
Comment 6 2019-03-12 12:03:08 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-03-12 12:04:22 PDT
<rdar://problem/48817670>
Note You need to log in before you can comment on or make changes to this bug.