WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
195520
[ContentChangeObserver] Click event fires immediately on hover menu at seriouseats.com
https://bugs.webkit.org/show_bug.cgi?id=195520
Summary
[ContentChangeObserver] Click event fires immediately on hover menu at seriou...
zalan
Reported
2019-03-09 07:27:05 PST
ssia
Attachments
Patch
(6.55 KB, patch)
2019-03-09 08:40 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(6.70 KB, patch)
2019-03-09 19:15 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(6.68 KB, patch)
2019-03-09 19:42 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2019-03-09 07:27:27 PST
<
rdar://problem/48740098
>
zalan
Comment 2
2019-03-09 08:40:37 PST
Created
attachment 364130
[details]
Patch
Simon Fraser (smfr)
Comment 3
2019-03-09 11:38:54 PST
Comment on
attachment 364130
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=364130&action=review
> Source/WebCore/ChangeLog:9 > + Unfortunately seriouseats has a 300ms hover intent delay to deal with accidental menupane pop-ups.
Maybe say something about the other changes in this patch.
> Source/WebCore/page/ios/ContentChangeObserver.cpp:352 > + if (style.hasOutOfFlowPosition() && left.isFixed() && left.value() <= -999) > + return true;
What about negative X? Don't you also need to check the element width? Something at -999 could be on-screen, especially if it has 100% width on iPad. You should also add a test for this.
zalan
Comment 4
2019-03-09 18:54:16 PST
(In reply to Simon Fraser (smfr) from
comment #3
)
> Comment on
attachment 364130
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=364130&action=review
> > > Source/WebCore/ChangeLog:9 > > + Unfortunately seriouseats has a 300ms hover intent delay to deal with accidental menupane pop-ups. > > Maybe say something about the other changes in this patch.
I did, it's next to "StyleChangeScope::isConsideredHidden const" but yeah, I should put some more words in there.
> > > Source/WebCore/page/ios/ContentChangeObserver.cpp:352 > > + if (style.hasOutOfFlowPosition() && left.isFixed() && left.value() <= -999) > > + return true; > > What about negative X? > Don't you also need to check the element width? Something at -999 could be > on-screen, especially if it has 100% width on iPad.
That case is covered already. This is about when we don't know the exact width (percent or calculated) and the _out-of-flow_ content seems suspiciously positioned to the far left.
> You should also add a test for this.
zalan
Comment 5
2019-03-09 19:15:00 PST
Created
attachment 364157
[details]
Patch
zalan
Comment 6
2019-03-09 19:42:36 PST
Created
attachment 364160
[details]
Patch
WebKit Commit Bot
Comment 7
2019-03-09 20:48:39 PST
Comment on
attachment 364160
[details]
Patch Clearing flags on attachment: 364160 Committed
r242679
: <
https://trac.webkit.org/changeset/242679
>
WebKit Commit Bot
Comment 8
2019-03-09 20:48:41 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug