Bug 19552 – JavaScriptCore headers use C++ style comments

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Christian Dywan]

The JavaScriptCore API is basically usable from C. However the public headers make use of C++ style "//" comments. That means only compilers supporting that part of C99 or particularly support for C++ style comments can parse these headers.

[Christian Dywan]

Created attachment 21710 [details]
Use only C style comments in public API headers

This patch replaces C++ style comments with C style comments in files that are relevant to public C API, which is JavaScript.h and all headers it includes.

[Christian Dywan]

Created attachment 21712 [details]
Use only C style comments, including CF and BSTR headers

Updated patch, including CF and BSTR headers. Also the "mode" lines should now say "c" instead of "c++" where appropriate.

[Sam Weinig]

Comment on attachment 21712 [details]
Use only C style comments, including CF and BSTR headers

This needs a ChangeLog.

[Darin Adler]

I don't think it's good for public header to have mode lines.

[Christian Dywan]

> I don't think it's good for public header to have mode lines.

I tend to agree here yet left them here because virtually all source files have them at the moment.

I will not commit for a few hours to see if there are others who would agree with removing the mode files entirely. Opinions welcome.

[Alexey Proskuryakov]

Yes, please remove the mode lines.

[Christian Dywan]

Comment on attachment 21712 [details]
Use only C style comments, including CF and BSTR headers

Committed in revision 34599. All mode lines were removed entierly.