Bug 195516 – Optimizing loads when creating new pages

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jiewen Tan]

Optimizing loads when creating new pages.

[Radar WebKit Bug Importer]

<rdar://problem/48738086>

[Jiewen Tan]

Created attachment 364123 [details]
Patch

[Jiewen Tan]

The internal counterpart is within: <rdar://problem/46325687>.

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Jiewen Tan]

Created attachment 364175 [details]
Patch

[Jiewen Tan]

Created attachment 364178 [details]
Patch

[Michael Catanzaro]

Comment on attachment 364178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364178&action=review

> Source/WebKit/UIProcess/WebPageProxy.h:2191
> +#if HAVE(LOAD_OPTIMIZER)
> +WEBPAGEPROXY_LOADOPTIMIZER_ADDITIONS_2
> +#endif

How do these hooks work?

It's strange that we would have non-open source code tightly coupled to open source like this. It's one thing to depend on an internal library, or to provide APIs for use by internal code, but just #including secret code into WebKit internals like this seems... unusual.

What gets optimized?

[Darin Adler]

Comment on attachment 364178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364178&action=review

r+ so Jiewen can keep making progress

>> Source/WebKit/UIProcess/WebPageProxy.h:2191
>> +#endif
> 
> How do these hooks work?
> 
> It's strange that we would have non-open source code tightly coupled to open source like this. It's one thing to depend on an internal library, or to provide APIs for use by internal code, but just #including secret code into WebKit internals like this seems... unusual.
> 
> What gets optimized?

I understand your unease. But this has happened multiple times before before when an engineer at Apple started development on something that Apple wasn't ready to reveal. I think it’s OK for now; we can discuss it in more detail when someone from Apple upstreams everything. And it’s all inside an #if.

[Jiewen Tan]

Comment on attachment 364178 [details]
Patch

Thanks Darin for r+ this patch.

[WebKit Commit Bot]

Comment on attachment 364178 [details]
Patch

Clearing flags on attachment: 364178

Committed r242697: <https://trac.webkit.org/changeset/242697>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

Reverted r242697 for reason:

Broke internal builders.

Committed r242705: <https://trac.webkit.org/changeset/242705>

[Jiewen Tan]

(In reply to Truitt Savell from comment #12)
> Reverted r242697 for reason:
> 
> Broke internal builders.
> 
> Committed r242705: <https://trac.webkit.org/changeset/242705>

Thanks for the heads up. I forgot that I have to land the OpenSource and Internal changes together. Will hold the same patch after the Internal one is ready to land.

[Jiewen Tan]

Committed r242760: <https://trac.webkit.org/changeset/242760>