Bug 195515 - REGRESSION(r242622): Web Inspector: Fix asserts "Overridden property is missing overridingProperty"
Summary: REGRESSION(r242622): Web Inspector: Fix asserts "Overridden property is missi...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
Keywords: InRadar
Depends on:
Reported: 2019-03-08 23:45 PST by Nikita Vasilyev
Modified: 2019-03-11 13:05 PDT (History)
4 users (show)

See Also:

Patch (1.90 KB, patch)
2019-03-08 23:49 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2019-03-08 23:45:34 PST
This has no user impact.

An assert triggers on every overridden property when Show Jump to Effective Property Button is disabled.
Comment 1 Radar WebKit Bug Importer 2019-03-08 23:45:49 PST
Comment 2 Nikita Vasilyev 2019-03-08 23:49:32 PST
Created attachment 364119 [details]
Comment 3 Matt Baker 2019-03-11 12:46:09 PDT
Comment on attachment 364119 [details]

rs=me. Maybe we should adopt a new pattern in the constructor of classes taking an optional delegate:

-    this._delegate = delegate || null;
+    this._delegate = delegate || {};

Then we could simplify tests throughout the class:

- if (this._delegate && this._delegate.someMethod) { ... }
+ if (this._delegate.someMethod) { ... }
Comment 4 WebKit Commit Bot 2019-03-11 13:05:12 PDT
Comment on attachment 364119 [details]

Clearing flags on attachment: 364119

Committed r242731: <https://trac.webkit.org/changeset/242731>
Comment 5 WebKit Commit Bot 2019-03-11 13:05:14 PDT
All reviewed patches have been landed.  Closing bug.