Bug 195504 - IntlDateTimeFormat can be shrunk by 32 bytes
Summary: IntlDateTimeFormat can be shrunk by 32 bytes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-08 17:39 PST by Robin Morisset
Modified: 2019-03-11 11:00 PDT (History)
9 users (show)

See Also:


Attachments
Patch (2.62 KB, patch)
2019-03-08 17:41 PST, Robin Morisset
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.61 MB, application/zip)
2019-03-08 23:49 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-03-08 17:39:18 PST
Primarily by shrinking enums, secondarily by moving a boolean to the end of the struct to minimize padding.
Comment 1 Robin Morisset 2019-03-08 17:41:22 PST
Created attachment 364099 [details]
Patch
Comment 2 EWS Watchlist 2019-03-08 23:49:36 PST
Comment on attachment 364099 [details]
Patch

Attachment 364099 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11436622

New failing tests:
accessibility/mac/selection-notification-focus-change.html
Comment 3 EWS Watchlist 2019-03-08 23:49:38 PST
Created attachment 364120 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 4 Robin Morisset 2019-03-11 10:19:00 PDT
Comment on attachment 364099 [details]
Patch

Flaky test.
Comment 5 WebKit Commit Bot 2019-03-11 10:55:05 PDT
Comment on attachment 364099 [details]
Patch

Clearing flags on attachment: 364099

Committed r242718: <https://trac.webkit.org/changeset/242718>
Comment 6 WebKit Commit Bot 2019-03-11 10:55:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-03-11 11:00:42 PDT
<rdar://problem/48773266>