Bug 195495 - Simplify DOMWindowProperty code / handling
Summary: Simplify DOMWindowProperty code / handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-08 16:38 PST by Chris Dumez
Modified: 2019-03-09 18:51 PST (History)
8 users (show)

See Also:


Attachments
WIP Patch (23.57 KB, patch)
2019-03-08 16:39 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.64 MB, application/zip)
2019-03-08 21:36 PST, EWS Watchlist
no flags Details
Patch (34.13 KB, patch)
2019-03-09 08:52 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.68 MB, application/zip)
2019-03-09 10:12 PST, EWS Watchlist
no flags Details
Patch (36.21 KB, patch)
2019-03-09 11:49 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (36.28 KB, patch)
2019-03-09 12:26 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-03-08 16:38:55 PST
Simplify DOMWindowProperty code / handling.
Comment 1 Chris Dumez 2019-03-08 16:39:43 PST
Created attachment 364089 [details]
WIP Patch
Comment 2 EWS Watchlist 2019-03-08 21:36:41 PST
Comment on attachment 364089 [details]
WIP Patch

Attachment 364089 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11435697

New failing tests:
compositing/video/video-clip-change-src.html
Comment 3 EWS Watchlist 2019-03-08 21:36:43 PST
Created attachment 364115 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 4 Chris Dumez 2019-03-09 08:52:49 PST
Created attachment 364131 [details]
Patch
Comment 5 EWS Watchlist 2019-03-09 10:12:49 PST
Comment on attachment 364131 [details]
Patch

Attachment 364131 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11439713

New failing tests:
compositing/video/video-clip-change-src.html
Comment 6 EWS Watchlist 2019-03-09 10:12:50 PST
Created attachment 364133 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 7 Chris Dumez 2019-03-09 11:08:05 PST
(In reply to Build Bot from comment #5)
> Comment on attachment 364131 [details]
> Patch
> 
> Attachment 364131 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: https://webkit-queues.webkit.org/results/11439713
> 
> New failing tests:
> compositing/video/video-clip-change-src.html

This is a flake, it passes locally with my patch and also fails on other bugs:
https://bugs.webkit.org/show_bug.cgi?id=195475#c5
Comment 8 Chris Dumez 2019-03-09 11:49:39 PST
Created attachment 364137 [details]
Patch
Comment 9 Chris Dumez 2019-03-09 12:26:24 PST
Created attachment 364138 [details]
Patch
Comment 10 Chris Dumez 2019-03-09 18:25:48 PST
Comment on attachment 364138 [details]
Patch

Clearing flags on attachment: 364138

Committed r242676: <https://trac.webkit.org/changeset/242676>
Comment 11 Chris Dumez 2019-03-09 18:25:50 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-03-09 18:51:29 PST
<rdar://problem/48745832>