Bug 195478 - [ContentChangeObserver] Expand "isConsideredClickable" to descendants
Summary: [ContentChangeObserver] Expand "isConsideredClickable" to descendants
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
Keywords: InRadar
Depends on:
Reported: 2019-03-08 14:06 PST by zalan
Modified: 2019-03-08 15:51 PST (History)
5 users (show)

See Also:

Patch (9.13 KB, patch)
2019-03-08 14:31 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (9.37 KB, patch)
2019-03-08 14:34 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (9.43 KB, patch)
2019-03-08 14:57 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-03-08 14:06:28 PST
In case when the visible content already had renderers it's not sufficient to check the "newly visible" element only since it might just be the container for the clickable content.
Comment 1 Radar WebKit Bug Importer 2019-03-08 14:06:54 PST
Comment 2 zalan 2019-03-08 14:31:57 PST
Created attachment 364068 [details]
Comment 3 zalan 2019-03-08 14:34:24 PST
Created attachment 364069 [details]
Comment 4 Simon Fraser (smfr) 2019-03-08 14:48:24 PST
Comment on attachment 364069 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=364069&action=review

> Source/WebCore/ChangeLog:9
> +        In StyleChangeScope we try to figure out whether a newly visible content should stick (menu panes etc) by checking if it is clickable.

"newly visible content"?

> Source/WebCore/page/ios/ContentChangeObserver.cpp:310
> +    if (!m_wasHidden || isConsideredHidden())

Would be clearer as if (changedFromHiddenToVisible())
Comment 5 zalan 2019-03-08 14:57:46 PST
Created attachment 364073 [details]
Comment 6 WebKit Commit Bot 2019-03-08 15:51:11 PST
Comment on attachment 364073 [details]

Clearing flags on attachment: 364073

Committed r242661: <https://trac.webkit.org/changeset/242661>
Comment 7 WebKit Commit Bot 2019-03-08 15:51:12 PST
All reviewed patches have been landed.  Closing bug.