We should add submit-to-ews url support, so as to submit the patch ids manually to EWS. This would also be required to make the 'Submit for EWS analysis' button work.
Created attachment 364065 [details] Proposed patch
Comment on attachment 364065 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=364065&action=review > Tools/BuildSlaveSupport/ews-app/ews/fetcher.py:53 > + def fetch(self, patch_ids=None): > + if not patch_ids: > + patch_ids = Bugzilla.get_list_of_patches_needing_reviews() We may want to check the type of patch_ids here. BugzillaPatchFetcher().fetch(1) will cause exceptions in next line. > Tools/BuildSlaveSupport/ews-app/ews/views/submittoews.py:40 > +@method_decorator(csrf_exempt, name='dispatch') Do we have a security justification for not having csrf here?
Created attachment 364269 [details] Patch for landing > We may want to check the type of patch_ids here. Added the check. > Do we have a security justification for not having csrf here? Removed csrf_exempt decorator. Updated templates accordingly (by adding {% csrf_token %})
Comment on attachment 364269 [details] Patch for landing Clearing flags on attachment: 364269 Committed r242719: <https://trac.webkit.org/changeset/242719>
All reviewed patches have been landed. Closing bug.
<rdar://problem/48774381>