Bug 195471 - Web Inspector: CPU Usage Timeline - Enable by default
Summary: Web Inspector: CPU Usage Timeline - Enable by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-08 10:49 PST by Joseph Pecoraro
Modified: 2019-03-11 14:32 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (21.45 KB, patch)
2019-03-08 10:50 PST, Joseph Pecoraro 		hi: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-03-08 10:49:20 PST 
CPU Usage Timeline - Enable by default

- And remove Legacy
Comment 1 Joseph Pecoraro 2019-03-08 10:50:32 PST 
Created attachment 364034 [details]
[PATCH] Proposed Fix
Comment 2 Devin Rousso 2019-03-08 17:56:34 PST 
Comment on attachment 364034 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364034&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:113
> +        if (WI.CPUInstrument.supported())
> +            defaultTypes.push(WI.TimelineRecord.Type.CPU);

Should we put this above the FPS instrument, seeing as it's shown in the same grouping as the other default types (e.g. the rendering frame timeline is a separate "view"/"tab" from Network/Layout/Script)?
Comment 3 Joseph Pecoraro 2019-03-11 14:31:08 PDT 
https://trac.webkit.org/r242741
Comment 4 Radar WebKit Bug Importer 2019-03-11 14:32:22 PDT 
<rdar://problem/48782918>