Bug 195470 - [ContentChangeObserver] Cleanup adjustObservedState
Summary: [ContentChangeObserver] Cleanup adjustObservedState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-08 10:46 PST by zalan
Modified: 2019-03-08 14:12 PST (History)
5 users (show)

See Also:


Attachments
Patch (7.20 KB, patch)
2019-03-08 10:55 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (7.20 KB, patch)
2019-03-08 10:57 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (8.86 KB, patch)
2019-03-08 12:43 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (8.86 KB, patch)
2019-03-08 13:34 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-03-08 10:46:23 PST
Move things around a bit.
Comment 1 Radar WebKit Bug Importer 2019-03-08 10:47:00 PST
<rdar://problem/48717823>
Comment 2 zalan 2019-03-08 10:55:21 PST
Created attachment 364035 [details]
Patch
Comment 3 zalan 2019-03-08 10:57:17 PST
Created attachment 364036 [details]
Patch
Comment 4 Simon Fraser (smfr) 2019-03-08 12:10:18 PST
Comment on attachment 364036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364036&action=review

> Source/WebCore/ChangeLog:9
> +        This is in preparation for introducing a observation window from touchStart -> mouseMoved.

an observation

> Source/WebCore/page/ios/ContentChangeObserver.cpp:102
> +    if (!m_domTimerIsBeingExecuted)

m_observedDomTimerIsBeingExecuted

> Source/WebCore/page/ios/ContentChangeObserver.cpp:123
> +    if (!m_styleRecalcIsBeingExecuted)

m_isInObservedStyleRecalc?
Comment 5 zalan 2019-03-08 12:43:40 PST
Created attachment 364051 [details]
Patch
Comment 6 zalan 2019-03-08 13:34:34 PST
Created attachment 364057 [details]
Patch
Comment 7 WebKit Commit Bot 2019-03-08 14:12:51 PST
Comment on attachment 364057 [details]
Patch

Clearing flags on attachment: 364057

Committed r242656: <https://trac.webkit.org/changeset/242656>
Comment 8 WebKit Commit Bot 2019-03-08 14:12:53 PST
All reviewed patches have been landed.  Closing bug.