Bug 195457 - [GTK] Several DNSTests are crashing
Summary: [GTK] Several DNSTests are crashing
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-08 05:03 PST by Diego Pino
Modified: 2021-10-27 21:32 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2019-03-08 05:03:14 PST 
Several DNS tests are crashing (https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/9929/steps/API%20tests/logs/stdio):

```
Unexpected crashes (3)
	/WebCore/TestWebCore
		DNSTest.cannotResolveDNS
		DNSTest.cancelResolveDNS
		DNSTest.resolveDNS
```

I looked into this issue and it seems the tests crash when attempting to access `soupNetworkSession()` (globalDefaultNetworkStorageSessionAccessor()().soupNetworkSession()). For instance:

https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/network/soup/DNSResolveQueueSoup.cpp#L95
https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/network/soup/DNSResolveQueueSoup.cpp#L187

I don't know when the tests stopped working. The earliest build tests results I could get were from r240433 and the tests were already crashing by then:

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/9480/steps/API%20tests/logs/stdio
Comment 1 Diego Pino 2021-10-27 21:32:06 PDT 
DNSResolveQueueSoup.cpp is no longer part of the codebase.