Bug 19545 - use PassRefPtr, not RefPtr, for return values
Summary: use PassRefPtr, not RefPtr, for return values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Trivial
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-14 00:44 PDT by Darin Adler
Modified: 2008-06-14 21:33 PDT (History)
0 users

See Also:

Attachments
patch (9.54 KB, patch)
2008-06-14 00:47 PDT, Darin Adler 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-06-14 00:44:48 PDT 
I noticed some places where RefPtr was used for a function return value.
Comment 1 Darin Adler 2008-06-14 00:47:07 PDT 
Created attachment 21697 [details]
patch
Comment 2 Adam Roben (:aroben) 2008-06-14 08:44:01 PDT 
Comment on attachment 21697 [details]
patch

There are changes to 4 functions in XSLTProcessor.h, but to only 3 functions in XSLTProcessor.cpp. Why is that?
Comment 3 Darin Adler 2008-06-14 10:19:26 PDT 
(In reply to comment #2)
> (From update of attachment 21697 [details] [edit])
> There are changes to 4 functions in XSLTProcessor.h, but to only 3 functions in
> XSLTProcessor.cpp. Why is that?

Because documentFromXMLDocPtr is declared in the header, but never defined. I'll just remove its declaration.
Comment 4 Sam Weinig 2008-06-14 18:11:11 PDT 
Comment on attachment 21697 [details]
patch

Gaa!
// Convert a libxml doc ptr to a KHTML DOM Document

r=me
Comment 5 Darin Adler 2008-06-14 21:33:19 PDT 
Committed revision 34551.