Bug 195449 - [JSC] Make more fields lazy in JSGlobalObject
Summary: [JSC] Make more fields lazy in JSGlobalObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-07 19:21 PST by Yusuke Suzuki
Modified: 2019-03-07 22:18 PST (History)
9 users (show)

See Also:


Attachments
Patch (28.61 KB, patch)
2019-03-07 19:25 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (32.90 KB, patch)
2019-03-07 20:26 PST, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-03-07 19:21:37 PST
[JSC] Make more fields lazy in JSGlobalObject
Comment 1 Yusuke Suzuki 2019-03-07 19:25:19 PST
Created attachment 363974 [details]
Patch
Comment 2 Yusuke Suzuki 2019-03-07 20:05:54 PST
Comment on attachment 363974 [details]
Patch

Oops, crashing. Investigating...
Comment 3 Yusuke Suzuki 2019-03-07 20:26:04 PST
Created attachment 363979 [details]
Patch
Comment 4 Mark Lam 2019-03-07 21:14:06 PST
Comment on attachment 363979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363979&action=review

r=me

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:317
> +  eval                  JSGlobalObject::m_evalFunction               DontEnum|CellProperty

Should you group this with the other CellPropertys below?  This list isn't in alphabetical order anyway.
Comment 5 Yusuke Suzuki 2019-03-07 21:15:09 PST
Comment on attachment 363979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363979&action=review

>> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:317
>> +  eval                  JSGlobalObject::m_evalFunction               DontEnum|CellProperty
> 
> Should you group this with the other CellPropertys below?  This list isn't in alphabetical order anyway.

OK, fixed :)
Comment 6 Yusuke Suzuki 2019-03-07 22:17:39 PST
Committed r242636: <https://trac.webkit.org/changeset/242636>
Comment 7 Radar WebKit Bug Importer 2019-03-07 22:18:24 PST
<rdar://problem/48702977>