Bug 195427 – [Web GPU] GPUSampler implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Justin Fan]

[Web GPU] GPUSampler implementation

[Radar WebKit Bug Importer]

<rdar://problem/48686011>

[Justin Fan]

Created attachment 363910 [details]
Patch

[EWS Watchlist]

Attachment 363910 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h:64:  The parameter name "const" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h:65:  The parameter name "const" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h:66:  The parameter name "const" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Justin Fan]

Created attachment 363913 [details]
Patch

[EWS Watchlist]

Attachment 363913 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h:64:  The parameter name "const" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h:65:  The parameter name "const" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h:66:  The parameter name "const" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Justin Fan]

Created attachment 363916 [details]
Patch

[EWS Watchlist]

Attachment 363916 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h:64:  The parameter name "const" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h:65:  The parameter name "const" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h:66:  The parameter name "const" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Comment on attachment 363916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363916&action=review

> Source/WebCore/platform/graphics/gpu/GPUSamplerDescriptor.h:63
> +    AddressMode addressModeU = AddressMode::ClampToEdge;
> +    AddressMode addressModeV = AddressMode::ClampToEdge;
> +    AddressMode addressModeW = AddressMode::ClampToEdge;
> +    FilterMode magFilter = FilterMode::Nearest;
> +    FilterMode minFilter = FilterMode::Nearest;
> +    FilterMode mipmapFilter = FilterMode::Nearest;
> +    float lodMinClamp = 0;
> +    float lodMaxClamp = 0xffffffff;
> +    unsigned maxAnisotropy = 1;
> +    GPUCompareFunction compareFunction = GPUCompareFunction::Never;
> +    BorderColor borderColor = BorderColor::TransparentBlack;

Is there any difference between this syntax and using AddressMode addressModeU { AddressMode::ClampToEdge }; ?

[Justin Fan]

(In reply to Dean Jackson from comment #8)
> Comment on attachment 363916 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=363916&action=review
> 
> > Source/WebCore/platform/graphics/gpu/GPUSamplerDescriptor.h:63
> > +    AddressMode addressModeU = AddressMode::ClampToEdge;
> > +    AddressMode addressModeV = AddressMode::ClampToEdge;
> > +    AddressMode addressModeW = AddressMode::ClampToEdge;
> > +    FilterMode magFilter = FilterMode::Nearest;
> > +    FilterMode minFilter = FilterMode::Nearest;
> > +    FilterMode mipmapFilter = FilterMode::Nearest;
> > +    float lodMinClamp = 0;
> > +    float lodMaxClamp = 0xffffffff;
> > +    unsigned maxAnisotropy = 1;
> > +    GPUCompareFunction compareFunction = GPUCompareFunction::Never;
> > +    BorderColor borderColor = BorderColor::TransparentBlack;
> 
> Is there any difference between this syntax and using AddressMode
> addressModeU { AddressMode::ClampToEdge }; ?

In this case there is no difference. I guess in the case of default initialization, brace initialization is a little less error-prone, but it's a style choice.

[Justin Fan]

Created attachment 363928 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 363928 [details]:

loader/load-defer-resume-crash.html bug 195438 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 363928 [details]
Patch for landing

Clearing flags on attachment: 363928

Committed r242615: <https://trac.webkit.org/changeset/242615>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.