[ContentChangeObserver] Check if max-height change triggers visible content change.

[zalan]

going from fixed max-height: 0px; to max-height: non-zero

[Radar WebKit Bug Importer]

<rdar://problem/48680631>

[zalan]

Created attachment 363897 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 363897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363897&action=review

> Source/WebCore/page/ios/ContentChangeObserver.cpp:299
>      if (left.isFixed() && width.isFixed() && -left.value() >= width.value())

This is stupid and you should add a comment to explain how stupid it is.

> Source/WebCore/page/ios/ContentChangeObserver.cpp:305
> +    auto maxHeight = style.maxHeight();

Maybe comment to say that height + overflow:hidden should also be checked at some point.

[zalan]

Created attachment 363985 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 363985 [details]
Patch

Clearing flags on attachment: 363985

Committed r242634: <https://trac.webkit.org/changeset/242634>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.