Bug 195410 - REGRESSION(r242364): [WPE] Do not stop the compositing run loop update timer on suspend
Summary: REGRESSION(r242364): [WPE] Do not stop the compositing run loop update timer ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2019-03-07 08:00 PST by Carlos Garcia Campos
Modified: 2019-03-07 09:18 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.29 KB, patch)
2019-03-07 08:05 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-03-07 08:00:27 PST 
Calling CompositingRunLoop::stopUpdates() on suspend is leaving the threaded compositor in an inconsistent state, failing to resume and stopping the updates forever. This is causing timeouts in WPE layout tests.
Comment 1 Carlos Garcia Campos 2019-03-07 08:05:58 PST 
Created attachment 363874 [details]
Patch
Comment 2 WebKit Commit Bot 2019-03-07 09:17:22 PST 
Comment on attachment 363874 [details]
Patch

Clearing flags on attachment: 363874

Committed r242597: <https://trac.webkit.org/changeset/242597>
Comment 3 WebKit Commit Bot 2019-03-07 09:17:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-03-07 09:18:19 PST 
<rdar://problem/48677179>