Bug 195406 - Make someWindow.frames, .self, .window always return someWindow
Summary: Make someWindow.frames, .self, .window always return someWindow
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on: 195409
  Show dependency treegraph
Reported: 2019-03-07 05:18 PST by Anne van Kesteren
Modified: 2019-03-29 17:22 PDT (History)
16 users (show)

See Also:

Patch (10.66 KB, patch)
2019-03-29 10:11 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (10.69 KB, patch)
2019-03-29 13:48 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (12.81 KB, patch)
2019-03-29 15:00 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2019-03-07 05:18:34 PST
Currently they no longer do once the browsing context goes away. I was initially inclined to endorse that model as it'd be one less reference to store on the global/realm, but given globalThis already does that it now seems pointless.

HTML: https://github.com/whatwg/html/pull/4410

wpt: https://github.com/web-platform-tests/wpt/pull/15720
Comment 1 Chris Dumez 2019-03-29 10:11:37 PDT
Created attachment 366279 [details]
Comment 2 Chris Dumez 2019-03-29 13:48:11 PDT
Created attachment 366305 [details]
Comment 3 Alex Christensen 2019-03-29 14:56:45 PDT
Comment on attachment 366305 [details]

Looks like WebKitDOMDOMWindow.cpp needs to change to use globalThis too.
Comment 4 Chris Dumez 2019-03-29 15:00:33 PDT
Created attachment 366307 [details]
Comment 5 EWS Watchlist 2019-03-29 15:02:23 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 6 WebKit Commit Bot 2019-03-29 17:21:36 PDT
Comment on attachment 366307 [details]

Clearing flags on attachment: 366307

Committed r243669: <https://trac.webkit.org/changeset/243669>
Comment 7 WebKit Commit Bot 2019-03-29 17:21:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-03-29 17:22:18 PDT