Bug 195392 – Exception is a JSCell, not a JSObject.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Hence, it should not insert from JSDestructibleObject.

[Mark Lam]

Created attachment 363828 [details]
work in progress for EWS testing only.

[Mark Lam]

(In reply to Mark Lam from comment #0)
> Hence, it should not insert from JSDestructibleObject.

That should have said:
Hence, it should not inherit from JSDestructibleObject.

Thank you auto-correct.

[Mark Lam]

Created attachment 363847 [details]
proposed patch.

[EWS Watchlist]

Attachment 363847 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 36 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Lam]

Created attachment 363848 [details]
proposed patch.

[Saam Barati]

Comment on attachment 363848 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=363848&action=review

> Source/JavaScriptCore/ChangeLog:31
> +           We'll leave these as is for now.  To facilitate the conversion from Exception*

I don’t understand why you need anything special here. We already define JSValue(JSCell*)

> Source/JavaScriptCore/runtime/JSCJSValueInlines.h:189
> +inline JSValue::JSValue(Exception* exception)

This isn’t needed

> Source/JavaScriptCore/runtime/JSCast.h:36
> +    if (!(!from || from->JSCell::inherits(*from->JSCell::vm(), std::remove_pointer<To>::type::info()))) {

OOPS

[Mark Lam]

Comment on attachment 363848 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=363848&action=review

Thanks for the review.

>> Source/JavaScriptCore/ChangeLog:31
>> +           We'll leave these as is for now.  To facilitate the conversion from Exception*
> 
> I don’t understand why you need anything special here. We already define JSValue(JSCell*)

You are right.  We don't need this.  All we need is to #include "Exception.h" in "Error.h" and "ExceptionHelper.h".  Fixed.

>> Source/JavaScriptCore/runtime/JSCJSValueInlines.h:189
>> +inline JSValue::JSValue(Exception* exception)
> 
> This isn’t needed

Removed.

>> Source/JavaScriptCore/runtime/JSCast.h:36
>> +    if (!(!from || from->JSCell::inherits(*from->JSCell::vm(), std::remove_pointer<To>::type::info()))) {
> 
> OOPS

Removed.

[Mark Lam]

Landed in r242596: <http://trac.webkit.org/r242596>.

[Radar WebKit Bug Importer]

<rdar://problem/48669863>