Bug 195391 – Remove an unneeded assert that was added with r242113

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

This assertion failure is seen with multiple layout tests after it was added in  https://trac.webkit.org/changeset/242113/webkit

ASSERTION FAILED: m_mediaBufferingIsSuspended
./page/Page.cpp(1784) : void WebCore::Page::resumeAllMediaBuffering()
1   0x493aeaee9 WTFCrash
2   0x497bb9c5b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x49a78750b WebCore::Page::resumeAllMediaBuffering()
4   0x102bea184 WebKit::WebPage::resumeAllMediaBuffering()
5   0x1028a83a6 WebKit::WebProcess::resumeAllMediaBuffering()
6   0x1028a8e2a WebKit::WebProcess::processDidResume()

see:
https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/r242569%20(2612)/results.html


It doesn't seem necessary since m_mediaBufferingIsSuspended is protected by an 'if' statement right below the ASSERT:

void Page::resumeAllMediaBuffering()
{
#if ENABLE(VIDEO)
    ASSERT(m_mediaBufferingIsSuspended);
    if (!m_mediaBufferingIsSuspended)
        return;
...

[Ryan Haddad]

Created attachment 363827 [details]
Patch

[Ryan Haddad]

<rdar://48642781>

[Radar WebKit Bug Importer]

<rdar://problem/48660996>

[WebKit Commit Bot]

Comment on attachment 363827 [details]
Patch

Clearing flags on attachment: 363827

Committed r242586: <https://trac.webkit.org/changeset/242586>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.