Bug 195383 – Resource Load Statistics: Make it possible to purge only script-accessible cookies

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[John Wilander]

We need the ability to purge all script-accessible cookies while leaving HttpOnly cookies in place.

[John Wilander]

<rdar://problem/48570136>

[John Wilander]

Created attachment 363806 [details]
Patch

[Alex Christensen]

Comment on attachment 363806 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363806&action=review

> Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:503
> +    deleteCookiesForHostnames(hostnames, true);

enum class IncludeHTTPOnlyCookies : bool { No, Yes };

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1603
> +    static NeverDestroyed<OptionSet<WebsiteDataType>> cookieType(std::initializer_list<WebsiteDataType>({ WebsiteDataType::Cookies }));

OptionSet fits in one register, so this is a little overkill.

[John Wilander]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 363806 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=363806&action=review
> 
> > Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:503
> > +    deleteCookiesForHostnames(hostnames, true);
> 
> enum class IncludeHTTPOnlyCookies : bool { No, Yes };
> 
> > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1603
> > +    static NeverDestroyed<OptionSet<WebsiteDataType>> cookieType(std::initializer_list<WebsiteDataType>({ WebsiteDataType::Cookies }));
> 
> OptionSet fits in one register, so this is a little overkill.

Thanks! Will fix both of these.

[John Wilander]

Created attachment 363830 [details]
Patch

[John Wilander]

Created attachment 363832 [details]
Patch

[John Wilander]

Created attachment 363833 [details]
Patch

[John Wilander]

Added build fixes for ports that use soup and curl.

[Brent Fulgham]

Comment on attachment 363833 [details]
Patch

Looks good. r=me. Please keep an eye on the test system after landing.

[John Wilander]

Comment on attachment 363833 [details]
Patch

Thanks, Brent!

[WebKit Commit Bot]

Comment on attachment 363833 [details]
Patch

Clearing flags on attachment: 363833

Committed r242598: <https://trac.webkit.org/changeset/242598>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.