Bug 195381 - Followups to (r242306): Use LockHolder instead of std::lock_guard on Remote Inspector Locks
Summary: Followups to (r242306): Use LockHolder instead of std::lock_guard on Remote I...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-06 14:51 PST by Christopher Reid
Modified: 2019-03-06 16:07 PST (History)
11 users (show)

See Also:


Attachments
Patch (25.38 KB, patch)
2019-03-06 15:07 PST, Christopher Reid
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Reid 2019-03-06 14:51:03 PST
In https://bugs.webkit.org/show_bug.cgi?id=193806, Don and Devin suggested to use `WTF::LockHolder` instead of `std::lock_guard` for the remote inspector Locks.
Darin also mentioned that `struct sockaddr_in address = { }` will initialize the struct without memset.
Comment 1 Christopher Reid 2019-03-06 15:07:06 PST
Created attachment 363798 [details]
Patch
Comment 2 Mark Lam 2019-03-06 15:12:04 PST
Comment on attachment 363798 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-03-06 16:06:53 PST
Comment on attachment 363798 [details]
Patch

Clearing flags on attachment: 363798

Committed r242576: <https://trac.webkit.org/changeset/242576>
Comment 4 WebKit Commit Bot 2019-03-06 16:06:54 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-06 16:07:46 PST
<rdar://problem/48656981>