Bug 195379 - [macOS] Sandbox call violation causes WebContent process to crash
Summary: [macOS] Sandbox call violation causes WebContent process to crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-06 14:29 PST by Per Arne Vollan
Modified: 2019-12-17 10:24 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.20 KB, patch)
2019-03-06 14:31 PST, Per Arne Vollan
bfulgham: review+
Details | Formatted Diff | Diff
Patch (1.28 KB, patch)
2019-03-06 14:40 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-03-06 14:29:26 PST
A new call needs to be added to the allow list in the WebContent process' sandbox.
Comment 1 Per Arne Vollan 2019-03-06 14:29:50 PST
rdar://problem/48647263
Comment 2 Per Arne Vollan 2019-03-06 14:31:34 PST
Created attachment 363794 [details]
Patch
Comment 3 Brent Fulgham 2019-03-06 14:33:40 PST
Comment on attachment 363794 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363794&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:972
> +        (syscall-number SYS_memorystatus_control)

I suggest you add a comment with the Radar#, or perhaps the reason we need to include this (e.g., list which Framework uses it.)

I this case, I think it night be:

"..._control) ;; Needed for memory measurement infrastructure"

Or something like that.
Comment 4 Per Arne Vollan 2019-03-06 14:40:57 PST
Created attachment 363795 [details]
Patch
Comment 5 Per Arne Vollan 2019-03-06 14:42:13 PST
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 363794 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=363794&action=review
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:972
> > +        (syscall-number SYS_memorystatus_control)
> 
> I suggest you add a comment with the Radar#, or perhaps the reason we need
> to include this (e.g., list which Framework uses it.)
> 
> I this case, I think it night be:
> 
> "..._control) ;; Needed for memory measurement infrastructure"
> 
> Or something like that.

Thanks for reviewing! I have updated the patch.
Comment 6 WebKit Commit Bot 2019-03-06 15:08:37 PST
Comment on attachment 363795 [details]
Patch

Clearing flags on attachment: 363795

Committed r242570: <https://trac.webkit.org/changeset/242570>