Bug 195377 - Web Inspector: DOM Debugger: event breakpoints still fire when breakpoints are disabled
Summary: Web Inspector: DOM Debugger: event breakpoints still fire when breakpoints ar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-06 14:04 PST by Devin Rousso
Modified: 2019-03-06 19:21 PST (History)
8 users (show)

See Also:


Attachments
Patch (7.28 KB, patch)
2019-03-06 15:06 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (7.33 KB, patch)
2019-03-06 15:17 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-highsierra (2.46 MB, application/zip)
2019-03-06 16:19 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.49 MB, application/zip)
2019-03-06 17:03 PST, EWS Watchlist
no flags Details
Patch (7.34 KB, patch)
2019-03-06 17:20 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-03-06 14:04:22 PST
# STEPS TO REPRODUCE:
1. open inspector2
2. set an event breakpoint on "click"
3. click on an element in the Elements tab
 => "scroll" breakpoint hit (expected)
4. disable breakpoints
5. continue
 => "scroll" breakpoint hit (unexpected)
Comment 1 Radar WebKit Bug Importer 2019-03-06 14:04:40 PST
<rdar://problem/48651645>
Comment 2 Devin Rousso 2019-03-06 15:06:28 PST
Created attachment 363797 [details]
Patch
Comment 3 Joseph Pecoraro 2019-03-06 15:09:39 PST
Comment on attachment 363797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363797&action=review

r=me, nice!

> LayoutTests/inspector/dom-debugger/event-listener-breakpoints-expected.txt:94
> +PASS: Should only pause once.

Maybe "Should only have paused once."
Comment 4 Matt Baker 2019-03-06 15:10:35 PST
Comment on attachment 363797 [details]
Patch

r=me
Comment 5 Matt Baker 2019-03-06 15:10:54 PST
Oops. r=Joe :)
Comment 6 Devin Rousso 2019-03-06 15:17:39 PST
Created attachment 363799 [details]
Patch
Comment 7 EWS Watchlist 2019-03-06 16:19:41 PST Comment hidden (obsolete)
Comment 8 EWS Watchlist 2019-03-06 16:19:43 PST Comment hidden (obsolete)
Comment 9 EWS Watchlist 2019-03-06 17:03:09 PST Comment hidden (obsolete)
Comment 10 EWS Watchlist 2019-03-06 17:03:11 PST Comment hidden (obsolete)
Comment 11 Devin Rousso 2019-03-06 17:20:27 PST
Created attachment 363823 [details]
Patch

Fix test structure/order for WK1.
Comment 12 WebKit Commit Bot 2019-03-06 19:21:25 PST
Comment on attachment 363823 [details]
Patch

Clearing flags on attachment: 363823

Committed r242588: <https://trac.webkit.org/changeset/242588>
Comment 13 WebKit Commit Bot 2019-03-06 19:21:26 PST
All reviewed patches have been landed.  Closing bug.