Bug 195373 - Hit-testing on layers overlapping scrollers should hit-test on text boxes
Summary: Hit-testing on layers overlapping scrollers should hit-test on text boxes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-06 13:25 PST by Simon Fraser (smfr)
Modified: 2019-03-26 00:37 PDT (History)
4 users (show)

See Also:

Attachments
Testcase (1.20 KB, text/html)
2019-03-06 13:25 PST, Simon Fraser (smfr) 		no flags Details
patch (7.62 KB, patch)
2019-03-25 06:19 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-03-06 13:25:16 PST 
Created attachment 363783 [details]
Testcase

If text overflows its parent box, when hit-testing the overflowing text we need to look at the text boxes.
Comment 1 Radar WebKit Bug Importer 2019-03-06 13:25:36 PST 
<rdar://problem/48649865>
Comment 2 Antti Koivisto 2019-03-25 06:19:20 PDT 
Created attachment 365861 [details]
patch
Comment 3 Simon Fraser (smfr) 2019-03-25 12:41:45 PDT 
Comment on attachment 365861 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365861&action=review

> LayoutTests/ChangeLog:9
> +        * fast/scrolling/ios/overflow-scroll-overlap-3.html:

Can we make a new test instead of extending an existing test? It makes failures harder to diagnose.
Comment 4 Antti Koivisto 2019-03-25 12:49:06 PDT 
> Can we make a new test instead of extending an existing test? It makes
> failures harder to diagnose.

That test case is already exclusively about this feature (with a subtest flipping). The patch just expands it.
Comment 5 WebKit Commit Bot 2019-03-26 00:12:53 PDT 
Comment on attachment 365861 [details]
patch

Clearing flags on attachment: 365861

Committed r243488: <https://trac.webkit.org/changeset/243488>
Comment 6 WebKit Commit Bot 2019-03-26 00:12:54 PDT 
All reviewed patches have been landed.  Closing bug.