Bug 195344 - Fix WKPasswordView compilation on iOS
Summary: Fix WKPasswordView compilation on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-05 15:32 PST by Dean Jackson
Modified: 2019-03-06 10:14 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.71 KB, patch)
2019-03-05 16:42 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (1.71 KB, patch)
2019-03-05 17:12 PST, Dean Jackson 		dbates: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-03-05 15:32:30 PST 
Add a platform define for UIColor system colors
Comment 1 Dean Jackson 2019-03-05 16:42:14 PST 
Created attachment 363708 [details]
Patch
Comment 2 Dean Jackson 2019-03-05 16:42:37 PST 
<rdar://problem/48620066>
Comment 3 Dean Jackson 2019-03-05 17:12:36 PST 
Created attachment 363710 [details]
Patch
Comment 4 Daniel Bates 2019-03-05 19:09:15 PST 
Comment on attachment 363710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363710&action=review

> Source/WebKit/UIProcess/ios/WKPasswordView.mm:110
>      [_scrollView setBackgroundColor:[UIColor groupTableViewBackgroundColor]];

Ok as is, but if you want to be a nice guy you could fix up this line up for all Apple Engineers (including me!). Search radars on Andy Estes whose title contains groupTableView.... or poke Andy with a stick (I tried but it wasn’t sharp enough ;))
Comment 5 Daniel Bates 2019-03-05 19:10:48 PST 
Comment on attachment 363710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363710&action=review

>> Source/WebKit/UIProcess/ios/WKPasswordView.mm:110
>>      [_scrollView setBackgroundColor:[UIColor groupTableViewBackgroundColor]];
> 
> Ok as is, but if you want to be a nice guy you could fix up this line up for all Apple Engineers (including me!). Search radars on Andy Estes whose title contains groupTableView.... or poke Andy with a stick (I tried but it wasn’t sharp enough ;))

Actually, depending on when SYSTEM COLORS is enabled you may have worked around the issue I am referring too at least for this callsite.... still applicable
To othe call sites.
Comment 6 Daniel Bates 2019-03-05 19:11:56 PST 
Digital poking (CC) Andy
Comment 7 Dean Jackson 2019-03-06 10:14:28 PST 
Committed r242552: <https://trac.webkit.org/changeset/242552>