Bug 195339 - op_switch_char broken for rope strings after JSRopeString layout rewrite
Summary: op_switch_char broken for rope strings after JSRopeString layout rewrite
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-05 13:18 PST by Saam Barati
Modified: 2019-03-05 16:20 PST (History)
14 users (show)

See Also:

Attachments
patch (4.93 KB, patch)
2019-03-05 13:24 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (4.94 KB, patch)
2019-03-05 13:26 PST, Saam Barati 		ysuzuki: review+
Details | Formatted Diff | Diff
patch for landing (5.54 KB, patch)
2019-03-05 14:39 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-03-05 13:18:46 PST 
...
Comment 1 Saam Barati 2019-03-05 13:19:59 PST 
<rdar://problem/48592545>
Comment 2 Saam Barati 2019-03-05 13:24:57 PST 
Created attachment 363680 [details]
patch
Comment 3 Saam Barati 2019-03-05 13:26:15 PST 
Created attachment 363681 [details]
patch
Comment 4 Yusuke Suzuki 2019-03-05 13:29:45 PST 
Comment on attachment 363681 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363681&action=review

r=me with a comment.

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1792
>      loadp JSString::m_fiber[t0], t0

Why not using `t1` for fiber0? Then, I think we do not need to add `move`.
Comment 5 Saam Barati 2019-03-05 14:39:10 PST 
Created attachment 363691 [details]
patch for landing
Comment 6 WebKit Commit Bot 2019-03-05 16:20:13 PST 
Comment on attachment 363691 [details]
patch for landing

Clearing flags on attachment: 363691

Committed r242519: <https://trac.webkit.org/changeset/242519>
Comment 7 WebKit Commit Bot 2019-03-05 16:20:14 PST 
All reviewed patches have been landed.  Closing bug.