Add support for Device Orientation / Motion permission API: - https://github.com/w3c/deviceorientation/issues/57
<rdar://problem/47645367>
Created attachment 363655 [details] Patch
Attachment 363655 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:487: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363663 [details] Patch
Attachment 363663 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:487: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 53 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363670 [details] Patch
Attachment 363670 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:487: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 53 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363673 [details] Patch
Attachment 363673 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:487: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 53 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363676 [details] Patch
Attachment 363676 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:487: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 54 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 363676 [details] Patch Will update as per Geoff's feedback offline.
Created attachment 363687 [details] Patch
Attachment 363687 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:487: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 54 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363693 [details] Patch
Attachment 363693 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:487: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 54 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363695 [details] Patch
Attachment 363695 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/ChromeClient.h:487: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 55 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 363695 [details] Patch Will merge orientation & motion permissions on native side.
Created attachment 363746 [details] Patch
Attachment 363746 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 65 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363747 [details] Patch
Attachment 363747 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 65 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363889 [details] Patch
Created attachment 363890 [details] Patch
Attachment 363890 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 69 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 363890 [details] Patch Will merge offline feedback from Youenn.
Created attachment 363930 [details] Patch
Attachment 363930 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 73 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363935 [details] Patch
Attachment 363935 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 76 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 364014 [details] Patch
Attachment 364014 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 76 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 364014 [details] Patch r=me
Comment on attachment 364014 [details] Patch Clearing flags on attachment: 364014 Committed r242664: <https://trac.webkit.org/changeset/242664>
All reviewed patches have been landed. Closing bug.
It looks like the changes in https://trac.webkit.org/changeset/242664/webkit has caused an API timeout on iOS: Timeout TestWebKitAPI.WebKit.WebsitePoliciesDeviceOrientationEventEnabled Received data during response processing, queuing it. I was able to confirm this locally using run-api-tests WebKit.WebsitePoliciesDeviceOrientationEventEnabled --ios-simulator The test will timeout on 242664 but not on 242663
(In reply to Truitt Savell from comment #37) > It looks like the changes in https://trac.webkit.org/changeset/242664/webkit > > has caused an API timeout on iOS: > Timeout > > TestWebKitAPI.WebKit.WebsitePoliciesDeviceOrientationEventEnabled > Received data during response processing, queuing it. > > > I was able to confirm this locally using > run-api-tests WebKit.WebsitePoliciesDeviceOrientationEventEnabled > --ios-simulator > > The test will timeout on 242664 but not on 242663 Looking now, thanks.
*** Bug 194183 has been marked as a duplicate of this bug. ***