Bug 195329 - Add support for Device Orientation / Motion permission API
Summary: Add support for Device Orientation / Motion permission API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://github.com/w3c/deviceorientat...
Keywords: InRadar
: 194183 (view as bug list)
Depends on: 195561
Blocks:
  Show dependency treegraph
 
Reported: 2019-03-05 09:16 PST by Chris Dumez
Modified: 2020-07-08 08:57 PDT (History)
12 users (show)

See Also:


Attachments
Patch (84.70 KB, patch)
2019-03-05 10:56 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (92.04 KB, patch)
2019-03-05 11:54 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (94.01 KB, patch)
2019-03-05 12:40 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (93.96 KB, patch)
2019-03-05 13:07 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (94.94 KB, patch)
2019-03-05 13:18 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (93.38 KB, patch)
2019-03-05 14:20 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (93.30 KB, patch)
2019-03-05 15:00 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (94.13 KB, patch)
2019-03-05 15:28 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (103.74 KB, patch)
2019-03-06 08:52 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (103.74 KB, patch)
2019-03-06 09:01 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (108.04 KB, patch)
2019-03-07 10:02 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (108.04 KB, patch)
2019-03-07 10:04 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (120.43 KB, patch)
2019-03-07 14:37 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (122.97 KB, patch)
2019-03-07 14:55 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (123.06 KB, patch)
2019-03-08 08:43 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-03-05 09:16:37 PST
Add support for Device Orientation / Motion permission API:
- https://github.com/w3c/deviceorientation/issues/57
Comment 1 Chris Dumez 2019-03-05 09:16:59 PST
<rdar://problem/47645367>
Comment 2 Chris Dumez 2019-03-05 10:56:11 PST
Created attachment 363655 [details]
Patch
Comment 3 EWS Watchlist 2019-03-05 11:00:26 PST
Attachment 363655 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:487:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Chris Dumez 2019-03-05 11:54:48 PST
Created attachment 363663 [details]
Patch
Comment 5 EWS Watchlist 2019-03-05 11:57:54 PST
Attachment 363663 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:487:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 53 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Chris Dumez 2019-03-05 12:40:30 PST
Created attachment 363670 [details]
Patch
Comment 7 EWS Watchlist 2019-03-05 12:43:29 PST
Attachment 363670 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:487:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 53 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Chris Dumez 2019-03-05 13:07:56 PST
Created attachment 363673 [details]
Patch
Comment 9 EWS Watchlist 2019-03-05 13:11:56 PST
Attachment 363673 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:487:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 53 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Chris Dumez 2019-03-05 13:18:03 PST
Created attachment 363676 [details]
Patch
Comment 11 EWS Watchlist 2019-03-05 13:21:16 PST
Attachment 363676 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:487:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 54 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Chris Dumez 2019-03-05 14:02:01 PST
Comment on attachment 363676 [details]
Patch

Will update as per Geoff's feedback offline.
Comment 13 Chris Dumez 2019-03-05 14:20:28 PST
Created attachment 363687 [details]
Patch
Comment 14 EWS Watchlist 2019-03-05 14:24:46 PST
Attachment 363687 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:487:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 54 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 Chris Dumez 2019-03-05 15:00:50 PST
Created attachment 363693 [details]
Patch
Comment 16 EWS Watchlist 2019-03-05 15:03:57 PST
Attachment 363693 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:487:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 54 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 17 Chris Dumez 2019-03-05 15:28:23 PST
Created attachment 363695 [details]
Patch
Comment 18 EWS Watchlist 2019-03-05 15:31:35 PST
Attachment 363695 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:487:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 55 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 19 Chris Dumez 2019-03-05 15:50:38 PST
Comment on attachment 363695 [details]
Patch

Will merge orientation & motion permissions on native side.
Comment 20 Chris Dumez 2019-03-06 08:52:48 PST
Created attachment 363746 [details]
Patch
Comment 21 EWS Watchlist 2019-03-06 08:56:27 PST
Attachment 363746 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 65 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 22 Chris Dumez 2019-03-06 09:01:40 PST
Created attachment 363747 [details]
Patch
Comment 23 EWS Watchlist 2019-03-06 09:04:54 PST
Attachment 363747 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 65 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 24 Chris Dumez 2019-03-07 10:02:52 PST
Created attachment 363889 [details]
Patch
Comment 25 Chris Dumez 2019-03-07 10:04:17 PST
Created attachment 363890 [details]
Patch
Comment 26 EWS Watchlist 2019-03-07 10:08:28 PST
Attachment 363890 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 69 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 27 Chris Dumez 2019-03-07 13:22:20 PST
Comment on attachment 363890 [details]
Patch

Will merge offline feedback from Youenn.
Comment 28 Chris Dumez 2019-03-07 14:37:20 PST
Created attachment 363930 [details]
Patch
Comment 29 EWS Watchlist 2019-03-07 14:41:30 PST
Attachment 363930 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 73 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 30 Chris Dumez 2019-03-07 14:55:36 PST
Created attachment 363935 [details]
Patch
Comment 31 EWS Watchlist 2019-03-07 14:59:25 PST
Attachment 363935 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 76 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 32 Chris Dumez 2019-03-08 08:43:18 PST
Created attachment 364014 [details]
Patch
Comment 33 EWS Watchlist 2019-03-08 08:45:49 PST
Attachment 364014 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:486:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 76 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 34 Geoffrey Garen 2019-03-08 15:42:28 PST
Comment on attachment 364014 [details]
Patch

r=me
Comment 35 WebKit Commit Bot 2019-03-08 16:30:52 PST
Comment on attachment 364014 [details]
Patch

Clearing flags on attachment: 364014

Committed r242664: <https://trac.webkit.org/changeset/242664>
Comment 36 WebKit Commit Bot 2019-03-08 16:30:54 PST
All reviewed patches have been landed.  Closing bug.
Comment 37 Truitt Savell 2019-03-11 09:19:26 PDT
It looks like the changes in https://trac.webkit.org/changeset/242664/webkit

has caused an API timeout on iOS:
Timeout

    TestWebKitAPI.WebKit.WebsitePoliciesDeviceOrientationEventEnabled
        Received data during response processing, queuing it.


I was able to confirm this locally using 
run-api-tests WebKit.WebsitePoliciesDeviceOrientationEventEnabled --ios-simulator

The test will timeout on 242664 but not on 242663
Comment 38 Chris Dumez 2019-03-11 09:27:35 PDT
(In reply to Truitt Savell from comment #37)
> It looks like the changes in https://trac.webkit.org/changeset/242664/webkit
> 
> has caused an API timeout on iOS:
> Timeout
> 
>     TestWebKitAPI.WebKit.WebsitePoliciesDeviceOrientationEventEnabled
>         Received data during response processing, queuing it.
> 
> 
> I was able to confirm this locally using 
> run-api-tests WebKit.WebsitePoliciesDeviceOrientationEventEnabled
> --ios-simulator
> 
> The test will timeout on 242664 but not on 242663

Looking now, thanks.
Comment 39 Chris Dumez 2020-07-08 08:57:04 PDT
*** Bug 194183 has been marked as a duplicate of this bug. ***