195298 – Web Inspector: Canvas: color swatches aren't shown for valid inputs with leading/trailing whitespace

Bug 195298 - Web Inspector: Canvas: color swatches aren't shown for valid inputs with leading/trailing whitespace

Summary: Web Inspector: Canvas: color swatches aren't shown for valid inputs with lead...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (show other bugs)
Version:	WebKit Nightly Build
Hardware:	All All

Importance:	P2 Normal
Assignee:	Devin Rousso

URL:
Keywords:	InRadar

Depends on:
Blocks:	WebInspectorCanvasTab
	Show dependency tree / graph

Reported:	2019-03-04 15:50 PST by Devin Rousso
Modified:	2019-03-06 11:21 PST (History)
CC List:	6 users (show)

See Also:

Attachments
Patch (2.71 KB, patch) 2019-03-04 15:57 PST, Devin Rousso	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.47 MB, application/zip) 2019-03-04 18:23 PST, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Devin Rousso 2019-03-04 15:50:44 PST

`context.fillStyle = "  red  ";` won't show a color swatch, whereas `context.fillStyle = "red";` does.

Comment 1 Devin Rousso 2019-03-04 15:57:53 PST

Created attachment 363562 [details]
Patch

Comment 2 EWS Watchlist 2019-03-04 18:23:51 PST Comment hidden (obsolete)

Comment on attachment 363562 [details]
Patch

Attachment 363562 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11369671

New failing tests:
fast/viewport/ios/device-width-viewport-after-changing-view-scale.html

Comment 3 EWS Watchlist 2019-03-04 18:23:53 PST Comment hidden (obsolete)

Created attachment 363579 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

Comment 4 WebKit Commit Bot 2019-03-06 11:08:34 PST

Comment on attachment 363562 [details]
Patch

Clearing flags on attachment: 363562

Committed r242553: <https://trac.webkit.org/changeset/242553>

Comment 5 WebKit Commit Bot 2019-03-06 11:08:35 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2019-03-06 11:21:21 PST

<rdar://problem/48645215>