Bug 195275 - CSS Text 3 WPT tests that fail after import
Summary: CSS Text 3 WPT tests that fail after import
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-04 06:29 PST by Javier Fernandez
Modified: 2019-12-18 09:34 PST (History)
10 users (show)

See Also:


Attachments
Patch (1.75 MB, patch)
2019-03-04 08:43 PST, Javier Fernandez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-highsierra (2.81 MB, application/zip)
2019-03-04 09:31 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.82 MB, application/zip)
2019-03-04 10:06 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews112 for mac-highsierra (2.10 MB, application/zip)
2019-03-04 10:45 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (3.01 MB, application/zip)
2019-03-04 11:02 PST, EWS Watchlist
no flags Details
Patch (1.76 MB, patch)
2019-03-04 14:51 PST, Javier Fernandez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (10.34 MB, application/zip)
2019-03-04 22:50 PST, EWS Watchlist
no flags Details
Patch (1.76 MB, patch)
2019-03-05 13:19 PST, Javier Fernandez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2019-03-04 06:29:47 PST
This bug is about importing the additional tests, and modifications, from the following test suite from web-platform-tests:
http://w3c-test.org/css/css-text/
Comment 1 Javier Fernandez 2019-03-04 08:43:30 PST
Created attachment 363514 [details]
Patch
Comment 2 EWS Watchlist 2019-03-04 09:31:58 PST
Comment on attachment 363514 [details]
Patch

Attachment 363514 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11363422

New failing tests:
imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-004.html
imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-001.html
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-003.html
imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001.html
imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-005.html
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-002.html
Comment 3 EWS Watchlist 2019-03-04 09:31:59 PST
Created attachment 363519 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 4 EWS Watchlist 2019-03-04 10:06:43 PST
Comment on attachment 363514 [details]
Patch

Attachment 363514 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11363651

New failing tests:
imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-004.html
imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-001.html
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-003.html
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-002.html
imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-005.html
imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001.html
Comment 5 EWS Watchlist 2019-03-04 10:06:45 PST
Created attachment 363522 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 6 EWS Watchlist 2019-03-04 10:45:29 PST
Comment on attachment 363514 [details]
Patch

Attachment 363514 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11363777

New failing tests:
imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-004.html
imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-001.html
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-003.html
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-002.html
imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-005.html
imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001.html
Comment 7 EWS Watchlist 2019-03-04 10:45:30 PST
Created attachment 363527 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 8 EWS Watchlist 2019-03-04 11:02:33 PST
Comment on attachment 363514 [details]
Patch

Attachment 363514 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11363808

New failing tests:
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-break-spaces-002.html
imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-004.html
imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-auto-001.html
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-003.html
imported/w3c/web-platform-tests/css/css-text/white-space/trailing-space-before-br-001.html
imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-005.html
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-002.html
Comment 9 EWS Watchlist 2019-03-04 11:02:35 PST
Created attachment 363528 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 10 Javier Fernandez 2019-03-04 14:51:56 PST
Created attachment 363553 [details]
Patch
Comment 11 Myles C. Maxfield 2019-03-04 14:55:03 PST
Comment on attachment 363553 [details]
Patch

Looks good to me, assuming ap doesn't object to making the layout tests take a little longer, and assuming all the bots are green
Comment 12 EWS Watchlist 2019-03-04 22:50:56 PST
Comment on attachment 363553 [details]
Patch

Attachment 363553 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11372639

New failing tests:
fast/scrolling/ios/hit-testing-iframe-002.html
imported/w3c/web-platform-tests/css/css-text/white-space/textarea-break-spaces-002.html
Comment 13 EWS Watchlist 2019-03-04 22:50:58 PST
Created attachment 363607 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 14 Javier Fernandez 2019-03-05 13:19:06 PST
Created attachment 363677 [details]
Patch
Comment 15 WebKit Commit Bot 2019-03-06 07:57:43 PST
Comment on attachment 363677 [details]
Patch

Clearing flags on attachment: 363677

Committed r242550: <https://trac.webkit.org/changeset/242550>
Comment 16 WebKit Commit Bot 2019-03-06 07:57:45 PST
All reviewed patches have been landed.  Closing bug.
Comment 17 Radar WebKit Bug Importer 2019-03-06 07:58:32 PST
<rdar://problem/48638251>
Comment 18 Diego Pino 2019-04-05 05:00:59 PDT
Tests:

- imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-004.html
. imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-005.html

were marked as [ ImageFailure Timeout ] when they were added. However, these tests have always been passing and there haven't been timeouts since then either.

I removed both tests from WPE/TesExpectations in r243930.
Comment 19 Carlos Alberto Lopez Perez 2019-12-18 09:29:27 PST
Re-opening this bug.

On r242550 the new WPT tests were imported, but 73 of those were imported as failing and the bug tagged to those failures is this one. So this bug should not be closed.

Check https://trac.webkit.org/changeset/242550/webkit/trunk/LayoutTests/TestExpectations
Comment 20 Carlos Alberto Lopez Perez 2019-12-18 09:34:45 PST
(In reply to Carlos Alberto Lopez Perez from comment #19)
> Re-opening this bug.
> 
> On r242550 the new WPT tests were imported, but 73 of those were imported as
> failing and the bug tagged to those failures is this one. So this bug should
> not be closed.
> 
> Check
> https://trac.webkit.org/changeset/242550/webkit/trunk/LayoutTests/
> TestExpectations

Currently there are 57 general failures tagged, 19 specific for GTK, 16 for WPE and 1 for iOS

$ grep -c webkit.org/b/195275 LayoutTests/TestExpectations
57

$ grep -c webkit.org/b/195275 LayoutTests/platform/*/TestExpectations|grep -v :0
LayoutTests/platform/gtk/TestExpectations:19
LayoutTests/platform/ios-simulator/TestExpectations:1
LayoutTests/platform/wpe/TestExpectations:16