Bug 195250 - [JSC] Make Reflect lazily-allocated by dropping @Reflect references from builtin JS
Summary: [JSC] Make Reflect lazily-allocated by dropping @Reflect references from buil...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-02 13:18 PST by Yusuke Suzuki
Modified: 2019-03-04 13:22 PST (History)
7 users (show)

See Also:

Attachments
Patch (11.08 KB, patch)
2019-03-02 13:21 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (11.49 KB, patch)
2019-03-02 13:25 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-03-02 13:18:44 PST 
[JSC] Make Reflect lazily-allocated by dropping @Reflect references from builtin JS
Comment 1 Yusuke Suzuki 2019-03-02 13:21:16 PST 
Created attachment 363430 [details]
Patch
Comment 2 Yusuke Suzuki 2019-03-02 13:25:43 PST 
Created attachment 363431 [details]
Patch
Comment 3 Saam Barati 2019-03-04 11:45:41 PST 
Comment on attachment 363431 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363431&action=review

> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:286
> +EncodedJSValue JSC_HOST_CALL objectConstructorOwnKeys(ExecState* exec)

Why not just make it a global function? I feel like we tend to have private properties reflect their public ones. But there is no corresponding public property here.
Comment 4 Yusuke Suzuki 2019-03-04 12:23:21 PST 
Comment on attachment 363431 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363431&action=review

Thanks!

>> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:286
>> +EncodedJSValue JSC_HOST_CALL objectConstructorOwnKeys(ExecState* exec)
> 
> Why not just make it a global function? I feel like we tend to have private properties reflect their public ones. But there is no corresponding public property here.

Yes, it looks better. I will put @ownKeys function in a global variable.
Comment 5 Yusuke Suzuki 2019-03-04 13:20:33 PST 
Committed r242382: <https://trac.webkit.org/changeset/242382>
Comment 6 Radar WebKit Bug Importer 2019-03-04 13:22:11 PST 
<rdar://problem/48574399>