The license headers in these two files contain the Apple license blurb, but the LGPL2 text should be used instead — because that one is the license we use for the API layer of the GTK port. A quick check with “git blame” shows that there are only a few people who have touched those: - Michael Catanzaro - Tomas Popela - Carlos Garcia Campos - Adrian Perez de Castro (that's me!) I'll try to get the authors to explicitly comment here that changing the license header is fine by them, before making the actual change.
Adding [WPE], because in bug #195211 the patch copied the GTK port headers, so the WPE headers have to be changed once everybody agrees. FWIW: I explicitly agree to change the license for these two files.
Oops. This is pretty minor, but yeah, let's change it. Explicit +1.
+1 from me as well. Thank you Adrian for spotting this!
Sure!
Thanks everybody for agreeing, I'll take care of making the patch to change the license blurbs :)
Created attachment 363503 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 363503 [details] Patch Clearing flags on attachment: 363503 Committed r242351: <https://trac.webkit.org/changeset/242351>
All reviewed patches have been landed. Closing bug.
<rdar://problem/48560805>