Bug 195245 - [GTK][WPE] Wrong license header in WebKit{,WebExtension}Autocleanups.h
Summary: [GTK][WPE] Wrong license header in WebKit{,WebExtension}Autocleanups.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-02 09:28 PST by Adrian Perez
Modified: 2019-03-04 06:30 PST (History)
8 users (show)

See Also:


Attachments
Patch (11.28 KB, patch)
2019-03-04 04:45 PST, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2019-03-02 09:28:58 PST
The license headers in these two files contain the Apple license blurb,
but the LGPL2 text should be used instead — because that one is the
license we use for the API layer of the GTK port.

A quick check with “git blame” shows that there are only a few people
who have touched those:

  - Michael Catanzaro
  - Tomas Popela
  - Carlos Garcia Campos
  - Adrian Perez de Castro (that's me!)

I'll try to get the authors to explicitly comment here that changing
the license header is fine by them, before making the actual change.
Comment 1 Adrian Perez 2019-03-02 09:31:57 PST
Adding [WPE], because in bug #195211 the patch copied the
GTK port headers, so the WPE headers have to be changed once
everybody agrees.

FWIW: I explicitly agree to change the license for these
two files.
Comment 2 Michael Catanzaro 2019-03-02 09:37:35 PST
Oops. This is pretty minor, but yeah, let's change it. Explicit +1.
Comment 3 Tomas Popela 2019-03-04 01:34:39 PST
+1 from me as well. Thank you Adrian for spotting this!
Comment 4 Carlos Garcia Campos 2019-03-04 01:48:43 PST
Sure!
Comment 5 Adrian Perez 2019-03-04 03:51:15 PST
Thanks everybody for agreeing, I'll take care of making the patch
to change the license blurbs :)
Comment 6 Adrian Perez 2019-03-04 04:45:57 PST
Created attachment 363503 [details]
Patch
Comment 7 Build Bot 2019-03-04 04:47:15 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 8 WebKit Commit Bot 2019-03-04 06:23:50 PST
Comment on attachment 363503 [details]
Patch

Clearing flags on attachment: 363503

Committed r242351: <https://trac.webkit.org/changeset/242351>
Comment 9 WebKit Commit Bot 2019-03-04 06:23:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-03-04 06:30:53 PST
<rdar://problem/48560805>