RESOLVED FIXED 195240
[ContentChangeObserver] Move away from WKContentChange values 
https://bugs.webkit.org/show_bug.cgi?id=195240
Summary [ContentChangeObserver] Move away from WKContentChange values
zalan
Reported 2019-03-01 21:08:03 PST
ssia
Attachments
Patch (12.22 KB, patch)
2019-03-01 21:15 PST, zalan 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-01 21:08:20 PST
<rdar://problem/48532358>
zalan
Comment 2 2019-03-01 21:15:10 PST
Created attachment 363409 [details] Patch
Simon Fraser (smfr)
Comment 3 2019-03-02 13:18:50 PST
Comment on attachment 363409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363409&action=review > Source/WebCore/ChangeLog:9 > + This is in preparation for moving towards a state machine like implementation. state machine-like > Source/WebCore/page/ios/ContentChangeObserver.cpp:133 > + LOG(ContentObservation, "stopObservingStyleRecalc: notify the pending synthetic click handler."); Mentioning synthetic clicks here indicates a layering problem, as we talked about. > Source/WebCore/page/ios/ContentChangeObserver.cpp:137 > + LOG(ContentObservation, "stopObservingStyleRecalc: can't decided it yet."); "can't decided it" ? > Source/WebCore/page/ios/ContentChangeObserver.cpp:193 > +bool ContentChangeObserver::hasDeterminedState() const So "determined" as an adjective means "intent on" as in "he was very determined". This should use "determinate", meaning "fixed" or "settled".
zalan
Comment 4 2019-03-02 14:57:25 PST
Committed r242319: <https://trac.webkit.org/changeset/242319>
Note You need to log in before you can comment on or make changes to this bug.