Bug 195240 - [ContentChangeObserver] Move away from WKContentChange values
Summary: [ContentChangeObserver] Move away from WKContentChange values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-01 21:08 PST by zalan
Modified: 2019-03-02 14:57 PST (History)
4 users (show)

See Also:

Attachments
Patch (12.22 KB, patch)
2019-03-01 21:15 PST, zalan 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-03-01 21:08:03 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2019-03-01 21:08:20 PST 
<rdar://problem/48532358>
Comment 2 zalan 2019-03-01 21:15:10 PST 
Created attachment 363409 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-03-02 13:18:50 PST 
Comment on attachment 363409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363409&action=review

> Source/WebCore/ChangeLog:9
> +        This is in preparation for moving towards a state machine like implementation.

state machine-like

> Source/WebCore/page/ios/ContentChangeObserver.cpp:133
> +        LOG(ContentObservation, "stopObservingStyleRecalc: notify the pending synthetic click handler.");

Mentioning synthetic clicks here indicates a layering problem, as we talked about.

> Source/WebCore/page/ios/ContentChangeObserver.cpp:137
> +    LOG(ContentObservation, "stopObservingStyleRecalc: can't decided it yet.");

"can't decided it" ?

> Source/WebCore/page/ios/ContentChangeObserver.cpp:193
> +bool ContentChangeObserver::hasDeterminedState() const

So "determined" as an adjective means "intent on" as in "he was very determined". This should use "determinate", meaning "fixed" or "settled".
Comment 4 zalan 2019-03-02 14:57:25 PST 
Committed r242319: <https://trac.webkit.org/changeset/242319>