[JSC] Fix FTL build on ARM32_64 by adding stubs for JSRopeString::offsetOfXXX
Created attachment 363390 [details] Patch
Comment on attachment 363390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review > Source/JavaScriptCore/runtime/JSString.h:567 > + static ptrdiff_t offsetOfFlags() { return 0; } > + static ptrdiff_t offsetOfFiber1Lower() { return 0; } > + static ptrdiff_t offsetOfFiber1Upper() { return 0; } > + static ptrdiff_t offsetOfFiber2Lower() { return 0; } > + static ptrdiff_t offsetOfFiber2Upper() { return 0; } please ASSERT_NOT_REACHED or similar.
Comment on attachment 363390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review >> Source/JavaScriptCore/runtime/JSString.h:567 >> + static ptrdiff_t offsetOfFiber2Upper() { return 0; } > > please ASSERT_NOT_REACHED or similar. Nice! Added.
Comment on attachment 363390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review > Source/JavaScriptCore/runtime/JSString.h:560 > + // FIXME: This is an temporary workaround to make JSC built on ARM64_32. Once we start calculating bits before stroing them to JSRopeString, /stroing/storing/
Comment on attachment 363390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review >> Source/JavaScriptCore/runtime/JSString.h:560 >> + // FIXME: This is an temporary workaround to make JSC built on ARM64_32. Once we start calculating bits before stroing them to JSRopeString, > > /stroing/storing/ Oops, nice catch. Fixed.
Committed r242299: <https://trac.webkit.org/changeset/242299>
<rdar://problem/48528954>