Bug 195235 - [JSC] Fix FTL build on ARM32_64 by adding stubs for JSRopeString::offsetOfXXX
Summary: [JSC] Fix FTL build on ARM32_64 by adding stubs for JSRopeString::offsetOfXXX
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-01 16:57 PST by Yusuke Suzuki
Modified: 2019-03-01 17:06 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.85 KB, patch)
2019-03-01 16:58 PST, Yusuke Suzuki
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-03-01 16:57:35 PST
[JSC] Fix FTL build on ARM32_64 by adding stubs for JSRopeString::offsetOfXXX
Comment 1 Yusuke Suzuki 2019-03-01 16:58:23 PST
Created attachment 363390 [details]
Patch
Comment 2 Saam Barati 2019-03-01 17:00:20 PST
Comment on attachment 363390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review

> Source/JavaScriptCore/runtime/JSString.h:567
> +    static ptrdiff_t offsetOfFlags() { return 0; }
> +    static ptrdiff_t offsetOfFiber1Lower() { return 0; }
> +    static ptrdiff_t offsetOfFiber1Upper() { return 0; }
> +    static ptrdiff_t offsetOfFiber2Lower() { return 0; }
> +    static ptrdiff_t offsetOfFiber2Upper() { return 0; }

please ASSERT_NOT_REACHED or similar.
Comment 3 Yusuke Suzuki 2019-03-01 17:01:04 PST
Comment on attachment 363390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review

>> Source/JavaScriptCore/runtime/JSString.h:567
>> +    static ptrdiff_t offsetOfFiber2Upper() { return 0; }
> 
> please ASSERT_NOT_REACHED or similar.

Nice! Added.
Comment 4 Mark Lam 2019-03-01 17:01:49 PST
Comment on attachment 363390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review

> Source/JavaScriptCore/runtime/JSString.h:560
> +    // FIXME: This is an temporary workaround to make JSC built on ARM64_32. Once we start calculating bits before stroing them to JSRopeString,

/stroing/storing/
Comment 5 Yusuke Suzuki 2019-03-01 17:04:47 PST
Comment on attachment 363390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review

>> Source/JavaScriptCore/runtime/JSString.h:560
>> +    // FIXME: This is an temporary workaround to make JSC built on ARM64_32. Once we start calculating bits before stroing them to JSRopeString,
> 
> /stroing/storing/

Oops, nice catch. Fixed.
Comment 6 Yusuke Suzuki 2019-03-01 17:05:36 PST
Committed r242299: <https://trac.webkit.org/changeset/242299>
Comment 7 Radar WebKit Bug Importer 2019-03-01 17:06:25 PST
<rdar://problem/48528954>