RESOLVED FIXED 195235
[JSC] Fix FTL build on ARM32_64 by adding stubs for JSRopeString::offsetOfXXX 
https://bugs.webkit.org/show_bug.cgi?id=195235
Summary [JSC] Fix FTL build on ARM32_64 by adding stubs for JSRopeString::offsetOfXXX
Yusuke Suzuki
Reported 2019-03-01 16:57:35 PST
[JSC] Fix FTL build on ARM32_64 by adding stubs for JSRopeString::offsetOfXXX
Attachments
Patch (2.85 KB, patch)
2019-03-01 16:58 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-03-01 16:58:23 PST
Created attachment 363390 [details] Patch
Saam Barati
Comment 2 2019-03-01 17:00:20 PST
Comment on attachment 363390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review > Source/JavaScriptCore/runtime/JSString.h:567 > + static ptrdiff_t offsetOfFlags() { return 0; } > + static ptrdiff_t offsetOfFiber1Lower() { return 0; } > + static ptrdiff_t offsetOfFiber1Upper() { return 0; } > + static ptrdiff_t offsetOfFiber2Lower() { return 0; } > + static ptrdiff_t offsetOfFiber2Upper() { return 0; } please ASSERT_NOT_REACHED or similar.
Yusuke Suzuki
Comment 3 2019-03-01 17:01:04 PST
Comment on attachment 363390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review >> Source/JavaScriptCore/runtime/JSString.h:567 >> + static ptrdiff_t offsetOfFiber2Upper() { return 0; } > > please ASSERT_NOT_REACHED or similar. Nice! Added.
Mark Lam
Comment 4 2019-03-01 17:01:49 PST
Comment on attachment 363390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review > Source/JavaScriptCore/runtime/JSString.h:560 > + // FIXME: This is an temporary workaround to make JSC built on ARM64_32. Once we start calculating bits before stroing them to JSRopeString, /stroing/storing/
Yusuke Suzuki
Comment 5 2019-03-01 17:04:47 PST
Comment on attachment 363390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review >> Source/JavaScriptCore/runtime/JSString.h:560 >> + // FIXME: This is an temporary workaround to make JSC built on ARM64_32. Once we start calculating bits before stroing them to JSRopeString, > > /stroing/storing/ Oops, nice catch. Fixed.
Yusuke Suzuki
Comment 6 2019-03-01 17:05:36 PST
Committed r242299: <https://trac.webkit.org/changeset/242299>
Radar WebKit Bug Importer
Comment 7 2019-03-01 17:06:25 PST
<rdar://problem/48528954>
Note You need to log in before you can comment on or make changes to this bug.