Bug 195230 - Disable NetworkStateNotifier::singleton()'s isMainThread() assertion when the WebThread is enabled
Summary: Disable NetworkStateNotifier::singleton()'s isMainThread() assertion when the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-01 14:47 PST by Chris Dumez
Modified: 2019-03-01 16:30 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2019-03-01 14:48 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (1.93 KB, patch)
2019-03-01 15:53 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-03-01 14:47:07 PST 
Disable NetworkStateNotifier::singleton()'s isMainThread() assertion when the WebThread is enabled to address crashes on iOS WK1.
Comment 1 Chris Dumez 2019-03-01 14:47:25 PST 
<rdar://problem/47925359>
Comment 2 Chris Dumez 2019-03-01 14:48:52 PST 
Created attachment 363378 [details]
Patch
Comment 3 Ryosuke Niwa 2019-03-01 14:59:30 PST 
Comment on attachment 363378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363378&action=review

> Source/WebCore/platform/network/NetworkStateNotifier.cpp:41
> +#if PLATFORM(IOS_FAMILY)

Why not #if USE(WEB_THREAD)?
Comment 4 Chris Dumez 2019-03-01 15:53:14 PST 
Created attachment 363386 [details]
Patch
Comment 5 WebKit Commit Bot 2019-03-01 16:30:44 PST 
Comment on attachment 363386 [details]
Patch

Clearing flags on attachment: 363386

Committed r242295: <https://trac.webkit.org/changeset/242295>
Comment 6 WebKit Commit Bot 2019-03-01 16:30:46 PST 
All reviewed patches have been landed.  Closing bug.