RESOLVED FIXED 195220
[ContentChangeObserver] Check for pending style recalcs at the end of each timer run. 
https://bugs.webkit.org/show_bug.cgi?id=195220
Summary [ContentChangeObserver] Check for pending style recalcs at the end of each ti...
zalan
Reported 2019-03-01 12:17:55 PST
instead of relying on didScheduleStyleRecalc since style recalc scheduling can turn into sync style recalcs.
Attachments
Patch (10.97 KB, patch)
2019-03-01 13:00 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (11.45 KB, patch)
2019-03-01 13:28 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-01 12:33:42 PST
<rdar://problem/48518979>
zalan
Comment 2 2019-03-01 13:00:18 PST
Created attachment 363362 [details] Patch
Simon Fraser (smfr)
Comment 3 2019-03-01 13:19:08 PST
Comment on attachment 363362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363362&action=review > Source/WebCore/ChangeLog:10 > + when in addition to this style recalc scheduling, something later (thouhg during the same timer firing) triggers a sync style recalc. thouhg > Source/WebCore/page/ios/ContentChangeObserver.cpp:99 > + auto inDeterminedState = observedContentChange == WKContentVisibilityChange || (!countOfObservedDOMTimers() && observedContentChange == WKContentNoChange && !hasPendingStyleRecalc); hasDeterminedState
Simon Fraser (smfr)
Comment 4 2019-03-01 13:21:29 PST
Comment on attachment 363362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363362&action=review > LayoutTests/fast/events/touch/ios/style-recalc-schedule-and-force-relalc.html:33 > + document.body.offsetHeight; Doesn't seem necessary. > LayoutTests/fast/events/touch/ios/style-recalc-schedule-and-force-relalc.html:34 > + testRunner.dumpAsText(); Normally we do this at the start > LayoutTests/fast/events/touch/ios/style-recalc-schedule-and-force-relalc.html:37 > + }, 100); Fix this.
zalan
Comment 5 2019-03-01 13:28:11 PST
Created attachment 363364 [details] Patch
WebKit Commit Bot
Comment 6 2019-03-01 14:49:00 PST
Comment on attachment 363364 [details] Patch Clearing flags on attachment: 363364 Committed r242290: <https://trac.webkit.org/changeset/242290>
WebKit Commit Bot
Comment 7 2019-03-01 14:49:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.