Bug 195215 - Improper use of PLATFORM(TVOS) in PAL
Summary: Improper use of PLATFORM(TVOS) in PAL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Conrad Shultz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-01 09:45 PST by Conrad Shultz
Modified: 2019-03-04 11:58 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.49 KB, patch)
2019-03-01 09:52 PST, Conrad Shultz 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Shultz 2019-03-01 09:45:09 PST 
There are a couple stray uses of PLATFORM(TVOS) in PAL. The correct usage is PLATFORM(APPLETV).
Comment 1 Conrad Shultz 2019-03-01 09:45:23 PST 
<rdar://problem/48512402>
Comment 2 Conrad Shultz 2019-03-01 09:52:14 PST 
Created attachment 363339 [details]
Patch
Comment 3 Conrad Shultz 2019-03-01 09:53:37 PST 
Style checker will fail due to existing issues, but I don't think we should address those as part of this change.
Comment 4 EWS Watchlist 2019-03-01 09:54:51 PST 
Attachment 363339 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:28:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:32:  Incorrect OS version check. VERSION_MIN_REQUIRED values never include a minor version. You may be looking for a combination of VERSION_MIN_REQUIRED for target OS version check and VERSION_MAX_ALLOWED for SDK check.  [build/version_check] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:32:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:34:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alexey Proskuryakov 2019-03-01 12:48:21 PST 
You probably don't have to, but this is a good opportunity to improve things.
Comment 6 Conrad Shultz 2019-03-04 10:44:16 PST 
(In reply to Alexey Proskuryakov from comment #5)
> You probably don't have to, but this is a good opportunity to improve things.

I'd like to do these in separate commits, in the unlikely event that addressing the style issues introduces unexpected problems.
Comment 7 Conrad Shultz 2019-03-04 11:58:55 PST 
Committed r242368: <https://trac.webkit.org/changeset/242368>