Bug 195215 – Improper use of PLATFORM(TVOS) in PAL

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Conrad Shultz]

There are a couple stray uses of PLATFORM(TVOS) in PAL. The correct usage is PLATFORM(APPLETV).

[Conrad Shultz]

<rdar://problem/48512402>

[Conrad Shultz]

Created attachment 363339 [details]
Patch

[Conrad Shultz]

Style checker will fail due to existing issues, but I don't think we should address those as part of this change.

[EWS Watchlist]

Attachment 363339 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:28:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:32:  Incorrect OS version check. VERSION_MIN_REQUIRED values never include a minor version. You may be looking for a combination of VERSION_MIN_REQUIRED for target OS version check and VERSION_MAX_ALLOWED for SDK check.  [build/version_check] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:32:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:34:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

You probably don't have to, but this is a good opportunity to improve things.

[Conrad Shultz]

(In reply to Alexey Proskuryakov from comment #5)
> You probably don't have to, but this is a good opportunity to improve things.

I'd like to do these in separate commits, in the unlikely event that addressing the style issues introduces unexpected problems.

[Conrad Shultz]

Committed r242368: <https://trac.webkit.org/changeset/242368>